Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new `--optional` flag #96

Closed
wants to merge 6 commits into from

Conversation

@ProLoser
Copy link

ProLoser commented Oct 30, 2019

Fixes #92 by providing a passthru flag

ProLoser added 4 commits Oct 30, 2019
Fixes #92 by providing a passthru flag
should not fail without an .env file if optional option is true
@ProLoser ProLoser force-pushed the ProLoser:patch-1 branch from 332bce5 to f02c363 Oct 30, 2019
@ProLoser

This comment has been minimized.

Copy link
Author

ProLoser commented Oct 30, 2019

Wow this is proving to be a pain in the ass to get working.

@toddbluhm

This comment has been minimized.

Copy link
Owner

toddbluhm commented Nov 1, 2019

@ProLoser This is an awesome PR, but per my comment on that issue, it appears throwing an error is actually a bug, not a feature. With that said, if you want to update this pr to ignore missing .env files feel free 😄 Perhaps maybe we should should log a warning if the .env file is missing rather than throwing an error.

@ProLoser ProLoser closed this Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.