Footer and search updates #157

merged 2 commits into from Nov 27, 2016


None yet

2 participants


The following PR removes unnecessary title attributes from footer links, as well as fixes an a11y bugs with the search component. Please see comments with the individual commits for more information.

scottaohara added some commits Nov 20, 2016
@scottaohara scottaohara removal of title attribute on footer links
titles should only be used if a link's visible text does not appropriately describe the destination of the link.  

the titles that were removed were merely duplicates of the visible text, so there was no benefit in keeping them.
@scottaohara scottaohara Update searchform.php
role="search" can not be placed on a ```<form>``` element, as it will overwrite the form's inherent role.  Instead, the search role should be applied to a ```<div>``` that wraps all the elements that make up the search component, within the ```<form>```.

Inputs should always have an a label associated with them. To rectify this, I've added an ```aria-label="Search:" to stand in for the label element.  

Removed the ```role="button"``` from the submit button, as it's redundant to the inherent semantics of the button element.
@oriSomething oriSomething merged commit 99eb037 into toddmotto:master Nov 27, 2016
@scottaohara scottaohara deleted the scottaohara:footer_and_search_updates branch Nov 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment