New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added use strict to improve kwalitee metric #2

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@mnlagrasta
Contributor

mnlagrasta commented May 13, 2015

Quick change to improve cpants kwalitee score based on the "use strict" rule. I verified all test still passed, but I obviously don't know nearly as much as you about RegEx usage, so you may want to do some more thorough tests before releasing this one. Sorry.

@toddr

This comment has been minimized.

Show comment
Hide comment
@toddr

toddr May 11, 2017

Owner

I'm not willing to add use Vars to this module. our @isa should work just as well

Owner

toddr commented May 11, 2017

I'm not willing to add use Vars to this module. our @isa should work just as well

@toddr

This comment has been minimized.

Show comment
Hide comment
@toddr

toddr Sep 11, 2017

Owner

Fixed additional errors and did the spirit of this work in master. closing.

Owner

toddr commented Sep 11, 2017

Fixed additional errors and did the spirit of this work in master. closing.

@toddr toddr closed this Sep 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment