Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2 - Add support for Git submodule projects #3

Merged
merged 1 commit into from Sep 16, 2019

Conversation

@Kevin-Lee
Copy link
Contributor

Kevin-Lee commented Aug 24, 2019

This PR solves the issue with git submodules.

For the details of the issue, please check out #2.
I haven't changed its version so you probably want to do it or if you like, I can do it. It's patch so 0.1.2 I guess?

e.g.)

sbt:test-project-switcher> pjs
  hedgehog
  example
  core
  tpsCore
  tpsCli
  justFp
  sbt-test
  runner
  tpsData
  tpsWeb
  root
> test
  12/12
> hedgehog
  1/12
> hed
sbt:test-project-switcher> pjs
[info] Set current project to hedgehog (in build file:/Users/kevin/git/kevin/tmp-projects/test-project-switcher/submodule/scala-hedgehog/)
[info] Set current project to hedgehog (in build file:/Users/kevin/git/kevin/tmp-projects/test-project-switcher/submodule/scala-hedgehog/)
sbt:hedgehog>

This fix also supports multiple sub-projects in the submodule project.


Another example

sbt:test-project-switcher> pjs
  hedgehog
  example
  core
  tpsCore
  tpsCli
  justFp
  sbt-test
> runner
  tpsData
  tpsWeb
  root
  test
  12/12
>
sbt:test-project-switcher> pjs
[info] Set current project to hedgehog (in build file:/Users/kevin/git/kevin/tmp-projects/test-project-switcher/submodule/scala-hedgehog/)
[info] Set current project to hedgehog-runner (in build file:/Users/kevin/git/kevin/tmp-projects/test-project-switcher/submodule/scala-hedgehog/)
sbt:hedgehog-runner>
@todokr

This comment has been minimized.

Copy link
Owner

todokr commented Sep 16, 2019

@Kevin-Lee Hi, Kevin! Sorry for my late reply.
I really appreciate it! It'll be great if you could make the version 0.1.2. Then I'll merge this :D

@Kevin-Lee Kevin-Lee force-pushed the Kevin-Lee:add-support-for-git-submodules branch from bd6b239 to e96a1ec Sep 16, 2019
@Kevin-Lee

This comment has been minimized.

Copy link
Contributor Author

Kevin-Lee commented Sep 16, 2019

@Kevin-Lee Hi, Kevin! Sorry for my late reply.
I really appreciate it! It'll be great if you could make the version 0.1.2. Then I'll merge this :D

@todokr Done! Thank you so much! 🙂

@todokr todokr merged commit b8ea1ed into todokr:master Sep 16, 2019
@todokr

This comment has been minimized.

Copy link
Owner

todokr commented Sep 16, 2019

@Kevin-Lee Merged! Thanks a lot! 👏

@Kevin-Lee

This comment has been minimized.

Copy link
Contributor Author

Kevin-Lee commented Sep 16, 2019

@todokr Great! Thanks. I really needed that fix. 🙂

@Kevin-Lee Kevin-Lee deleted the Kevin-Lee:add-support-for-git-submodules branch Sep 16, 2019
@Kevin-Lee

This comment has been minimized.

Copy link
Contributor Author

Kevin-Lee commented Sep 16, 2019

@todokr I'm wondering if it will be automatically released?

@Kevin-Lee

This comment has been minimized.

Copy link
Contributor Author

Kevin-Lee commented Sep 16, 2019

@todokr Sorry. Never mind. I can see that there's 0.1.2 available now. Thanks! 🙂👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.