From 54fd5b3039ce301eef74565e1cf7bf231237c990 Mon Sep 17 00:00:00 2001 From: Johnny Pribyl Date: Fri, 18 Sep 2020 08:07:22 -0600 Subject: [PATCH] Enable source maps for DevTools production builds (#19773) Co-authored-by: Brian Vaughn --- packages/react-devtools-core/webpack.backend.js | 2 +- packages/react-devtools-core/webpack.standalone.js | 2 +- packages/react-devtools-extensions/chrome/manifest.json | 9 ++++++++- packages/react-devtools-extensions/edge/manifest.json | 9 ++++++++- packages/react-devtools-extensions/firefox/manifest.json | 9 ++++++++- packages/react-devtools-extensions/webpack.backend.js | 2 +- packages/react-devtools-extensions/webpack.config.js | 2 +- packages/react-devtools-inline/webpack.config.js | 2 +- .../react-devtools-scheduling-profiler/webpack.config.js | 2 +- packages/react-devtools-shell/webpack.config.js | 2 +- 10 files changed, 31 insertions(+), 10 deletions(-) diff --git a/packages/react-devtools-core/webpack.backend.js b/packages/react-devtools-core/webpack.backend.js index 1461545d29d5..336ae310affd 100644 --- a/packages/react-devtools-core/webpack.backend.js +++ b/packages/react-devtools-core/webpack.backend.js @@ -19,7 +19,7 @@ const DEVTOOLS_VERSION = getVersionString(); module.exports = { mode: __DEV__ ? 'development' : 'production', - devtool: __DEV__ ? 'cheap-module-eval-source-map' : false, + devtool: __DEV__ ? 'cheap-module-eval-source-map' : 'source-map', entry: { backend: './src/backend.js', }, diff --git a/packages/react-devtools-core/webpack.standalone.js b/packages/react-devtools-core/webpack.standalone.js index 61c1d962372b..4d00d0f2d3a6 100644 --- a/packages/react-devtools-core/webpack.standalone.js +++ b/packages/react-devtools-core/webpack.standalone.js @@ -19,7 +19,7 @@ const DEVTOOLS_VERSION = getVersionString(); module.exports = { mode: __DEV__ ? 'development' : 'production', - devtool: __DEV__ ? 'cheap-module-eval-source-map' : false, + devtool: __DEV__ ? 'cheap-module-eval-source-map' : 'source-map', target: 'electron-main', entry: { standalone: './src/standalone.js', diff --git a/packages/react-devtools-extensions/chrome/manifest.json b/packages/react-devtools-extensions/chrome/manifest.json index f8abb8f49ec2..60fd566a5ebd 100644 --- a/packages/react-devtools-extensions/chrome/manifest.json +++ b/packages/react-devtools-extensions/chrome/manifest.json @@ -32,7 +32,14 @@ "main.html", "panel.html", "build/react_devtools_backend.js", - "build/renderer.js" + "build/renderer.js", + "build/background.js.map", + "build/contentScript.js.map", + "build/injectGlobalHook.js.map", + "build/main.js.map", + "build/panel.js.map", + "build/renderer.js.map", + "build/react_devtools_backend.js.map" ], "background": { diff --git a/packages/react-devtools-extensions/edge/manifest.json b/packages/react-devtools-extensions/edge/manifest.json index 9e3b46f73a87..3fbb2900bd64 100644 --- a/packages/react-devtools-extensions/edge/manifest.json +++ b/packages/react-devtools-extensions/edge/manifest.json @@ -32,7 +32,14 @@ "main.html", "panel.html", "build/react_devtools_backend.js", - "build/renderer.js" + "build/renderer.js", + "build/background.js.map", + "build/contentScript.js.map", + "build/injectGlobalHook.js.map", + "build/main.js.map", + "build/panel.js.map", + "build/renderer.js.map", + "build/react_devtools_backend.js.map" ], "background": { diff --git a/packages/react-devtools-extensions/firefox/manifest.json b/packages/react-devtools-extensions/firefox/manifest.json index d380a6dbdad2..ebe8547f10f5 100644 --- a/packages/react-devtools-extensions/firefox/manifest.json +++ b/packages/react-devtools-extensions/firefox/manifest.json @@ -37,7 +37,14 @@ "main.html", "panel.html", "build/react_devtools_backend.js", - "build/renderer.js" + "build/renderer.js", + "build/background.js.map", + "build/contentScript.js.map", + "build/injectGlobalHook.js.map", + "build/main.js.map", + "build/panel.js.map", + "build/renderer.js.map", + "build/react_devtools_backend.js.map" ], "background": { diff --git a/packages/react-devtools-extensions/webpack.backend.js b/packages/react-devtools-extensions/webpack.backend.js index 2399c10892e3..c9f1c336b026 100644 --- a/packages/react-devtools-extensions/webpack.backend.js +++ b/packages/react-devtools-extensions/webpack.backend.js @@ -18,7 +18,7 @@ const DEVTOOLS_VERSION = getVersionString(); module.exports = { mode: __DEV__ ? 'development' : 'production', - devtool: __DEV__ ? 'cheap-module-eval-source-map' : false, + devtool: __DEV__ ? 'cheap-module-eval-source-map' : 'source-map', entry: { backend: './src/backend.js', }, diff --git a/packages/react-devtools-extensions/webpack.config.js b/packages/react-devtools-extensions/webpack.config.js index 162d418d83c3..e2720ec240a9 100644 --- a/packages/react-devtools-extensions/webpack.config.js +++ b/packages/react-devtools-extensions/webpack.config.js @@ -18,7 +18,7 @@ const DEVTOOLS_VERSION = getVersionString(); module.exports = { mode: __DEV__ ? 'development' : 'production', - devtool: __DEV__ ? 'cheap-module-eval-source-map' : false, + devtool: __DEV__ ? 'cheap-module-eval-source-map' : 'source-map', entry: { background: './src/background.js', contentScript: './src/contentScript.js', diff --git a/packages/react-devtools-inline/webpack.config.js b/packages/react-devtools-inline/webpack.config.js index d841f48199e7..85c7da82ea3e 100644 --- a/packages/react-devtools-inline/webpack.config.js +++ b/packages/react-devtools-inline/webpack.config.js @@ -17,7 +17,7 @@ const DEVTOOLS_VERSION = getVersionString(); module.exports = { mode: __DEV__ ? 'development' : 'production', - devtool: false, + devtool: __DEV__ ? 'eval-cheap-source-map' : 'source-map', entry: { backend: './src/backend.js', frontend: './src/frontend.js', diff --git a/packages/react-devtools-scheduling-profiler/webpack.config.js b/packages/react-devtools-scheduling-profiler/webpack.config.js index 6f7028eea26c..b69a5d1b411e 100644 --- a/packages/react-devtools-scheduling-profiler/webpack.config.js +++ b/packages/react-devtools-scheduling-profiler/webpack.config.js @@ -40,7 +40,7 @@ const babelOptions = { const config = { mode: __DEV__ ? 'development' : 'production', - devtool: __DEV__ ? 'cheap-module-eval-source-map' : false, + devtool: __DEV__ ? 'cheap-module-eval-source-map' : 'source-map', entry: { app: './src/index.js', }, diff --git a/packages/react-devtools-shell/webpack.config.js b/packages/react-devtools-shell/webpack.config.js index b1c737f6fa56..500fed2fb12e 100644 --- a/packages/react-devtools-shell/webpack.config.js +++ b/packages/react-devtools-shell/webpack.config.js @@ -25,7 +25,7 @@ const DEVTOOLS_VERSION = getVersionString(); const config = { mode: __DEV__ ? 'development' : 'production', - devtool: false, + devtool: __DEV__ ? 'cheap-module-eval-source-map' : 'source-map', entry: { app: './src/app/index.js', devtools: './src/devtools.js',