New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2 #482

Open
karbassi opened this Issue Oct 2, 2017 · 15 comments

Comments

Projects
None yet
7 participants
@karbassi
Member

karbassi commented Oct 2, 2017

We need some help updating this app!

Critical

  • Dropbox v1 to v2 (#481)
  • Change build system to Gradle (#369, #485)

Deployment

  • Push to Google Play Store, Amazon App Store, and F-Droid (#477)
@KingIdee

This comment has been minimized.

Show comment
Hide comment
@KingIdee

KingIdee Oct 5, 2017

Okay! I'm coming in as a contributor! Can we migrate this app to the Gradle build system?

KingIdee commented Oct 5, 2017

Okay! I'm coming in as a contributor! Can we migrate this app to the Gradle build system?

@karbassi

This comment has been minimized.

Show comment
Hide comment
@karbassi

karbassi Oct 5, 2017

Member

@KingIdee Sounds good. Create a new issue with the tasks that you're going to do. Then create a branch with your changes. We'll review the PR and help out whenever you need it.

Need anything right now?

Member

karbassi commented Oct 5, 2017

@KingIdee Sounds good. Create a new issue with the tasks that you're going to do. Then create a branch with your changes. We'll review the PR and help out whenever you need it.

Need anything right now?

@KingIdee

This comment has been minimized.

Show comment
Hide comment
@KingIdee

KingIdee Oct 6, 2017

Okay noted!

KingIdee commented Oct 6, 2017

Okay noted!

@maysam

This comment has been minimized.

Show comment
Hide comment
@maysam

maysam Oct 7, 2017

Contributor

Can we convert this to kotlin?

Contributor

maysam commented Oct 7, 2017

Can we convert this to kotlin?

@karbassi

This comment has been minimized.

Show comment
Hide comment
@karbassi

karbassi Oct 7, 2017

Member

@maysam Create a new issue with the tasks that you're going to do. Then create a branch with your changes. We'll review the PR and help out whenever you need it.

Please reach out to @KingIdee to see if they have anything in progress and/or if you two can work together.

Member

karbassi commented Oct 7, 2017

@maysam Create a new issue with the tasks that you're going to do. Then create a branch with your changes. We'll review the PR and help out whenever you need it.

Please reach out to @KingIdee to see if they have anything in progress and/or if you two can work together.

@KingIdee

This comment has been minimized.

Show comment
Hide comment
@KingIdee

KingIdee Oct 7, 2017

Kotlin is cool by me. Can we work together @maysam But the project is not even building. I am having errors with some modules added in the
like /home/idee/.gradle/caches/transforms-1/files-1.1/actionbarsherlock-4.4.0.aar/c59d14a0a2efc8bb75660610e6915909/res/values/values.xml
Error:(473, 5) resource android:attr/popupPromptView is private Are you aware of this ?

KingIdee commented Oct 7, 2017

Kotlin is cool by me. Can we work together @maysam But the project is not even building. I am having errors with some modules added in the
like /home/idee/.gradle/caches/transforms-1/files-1.1/actionbarsherlock-4.4.0.aar/c59d14a0a2efc8bb75660610e6915909/res/values/values.xml
Error:(473, 5) resource android:attr/popupPromptView is private Are you aware of this ?

@karbassi

This comment has been minimized.

Show comment
Hide comment
@karbassi

karbassi Oct 9, 2017

Member

@KingIdee @maysam we also have a chatroom if you'd like to talk in there for quicker responses. https://gitter.im/todotxt/todo.txt-android

Member

karbassi commented Oct 9, 2017

@KingIdee @maysam we also have a chatroom if you'd like to talk in there for quicker responses. https://gitter.im/todotxt/todo.txt-android

@karbassi karbassi added bug sync labels Oct 9, 2017

@karbassi karbassi added this to the Version 2.0.0 milestone Oct 9, 2017

@evanp

This comment has been minimized.

Show comment
Hide comment
@evanp

evanp Dec 15, 2017

Member

Where are we on this?

Member

evanp commented Dec 15, 2017

Where are we on this?

@mikeofmany

This comment has been minimized.

Show comment
Hide comment
@mikeofmany

mikeofmany Dec 24, 2017

So move to Gradle.. is the github fork dead?

mikeofmany commented Dec 24, 2017

So move to Gradle.. is the github fork dead?

@karbassi

This comment has been minimized.

Show comment
Hide comment
@karbassi

karbassi Dec 25, 2017

Member

@mikeofmany Yes, would love to move to Gradle.

As a status update, we're waiting for any android devs to join the project to help us move to Gradle and fix things. Please put the call out!

Member

karbassi commented Dec 25, 2017

@mikeofmany Yes, would love to move to Gradle.

As a status update, we're waiting for any android devs to join the project to help us move to Gradle and fix things. Please put the call out!

@dae3

This comment has been minimized.

Show comment
Hide comment
@dae3

dae3 Mar 10, 2018

Contributor

@karbassi @KingIdee I have a minimum working Gradle build here. It builds and starts on a Nexus 5 API 27 emulator but crashes after clicking Connect To Dropbox. I suspect this is related to #481, which I plan to take a look at next.

Contributor

dae3 commented Mar 10, 2018

@karbassi @KingIdee I have a minimum working Gradle build here. It builds and starts on a Nexus 5 API 27 emulator but crashes after clicking Connect To Dropbox. I suspect this is related to #481, which I plan to take a look at next.

@evanp

This comment has been minimized.

Show comment
Hide comment
@evanp

evanp Mar 13, 2018

Member

@dae3 did you do anything besides the automated conversion to Gradle? Or did you put it together by hand?

Member

evanp commented Mar 13, 2018

@dae3 did you do anything besides the automated conversion to Gradle? Or did you put it together by hand?

@evanp

This comment has been minimized.

Show comment
Hide comment
@evanp

evanp Mar 13, 2018

Member

Ugh, please don't convert this project to Kotlin until there's a version that a) builds on Android Studio and b) uses the new Dropbox API. After that, go crazy!

Member

evanp commented Mar 13, 2018

Ugh, please don't convert this project to Kotlin until there's a version that a) builds on Android Studio and b) uses the new Dropbox API. After that, go crazy!

@dae3

This comment has been minimized.

Show comment
Hide comment
@dae3

dae3 Mar 13, 2018

Contributor

@evanp automated conversion to begin then, pulled as many sub-project dependencies as possible out into references to external repos (Maven Central, etc.), then a bit of manual tweaking to get it to build.

@maysam I'd consider Kotlin for any new code but wasn't planning anything yet. Any Kotlin references in there have been generated by Android Studio.

Contributor

dae3 commented Mar 13, 2018

@evanp automated conversion to begin then, pulled as many sub-project dependencies as possible out into references to external repos (Maven Central, etc.), then a bit of manual tweaking to get it to build.

@maysam I'd consider Kotlin for any new code but wasn't planning anything yet. Any Kotlin references in there have been generated by Android Studio.

@beavel

This comment has been minimized.

Show comment
Hide comment
@beavel

beavel Jun 18, 2018

I started work on #481 over here https://github.com/beavel/todo.txt-android . I'm not a Java programmer by any means as today has been my first day in the language, so any veteran eyes are welcome. My goal is to get something that will actually compile and build the apk first and then make sure it is functionally correct. I'm assuming the Gradle cutover is complete.

beavel commented Jun 18, 2018

I started work on #481 over here https://github.com/beavel/todo.txt-android . I'm not a Java programmer by any means as today has been my first day in the language, so any veteran eyes are welcome. My goal is to get something that will actually compile and build the apk first and then make sure it is functionally correct. I'm assuming the Gradle cutover is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment