Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Make install #90

Merged
merged 1 commit into from Jun 16, 2013

Conversation

Projects
None yet
5 participants
Contributor

danohuiginn commented Apr 28, 2012

Automates the setup process. with this, you can do complete setup with

$ git clone git://github.com/danohuiginn/todo.txt-cli.git
$ cd todo.txt-cli
$ sudo make install

Did this for my own benefit; if you actually want to include it, I'm happy to add documentation, make it more robust, etc. Currently works on ubuntu; assume it'll be OK on other linuxes, not sure about macs.

Member

inkarkat commented Apr 28, 2012

Great, I like it! Two comments:

How about installing todo.cfg system-wide (/etc/todo/config?), too, as other users have to base their configuration on something. (We're currently requiring a user config; I know, it would be better to have the script fall back to a system-wide default config to avoid this hassle.)

How about adding a make userinstall target that installs everything into $HOME; I guess this is what most users still do. (And nowadays there are few actually shared systems, mostly individual-user PCs, this distinction isn't that relevant, anyway.)

Owner

ginatrapani commented May 12, 2012

I'd be happy to include this in the master branch once we have documentation. I can test on OS X and Cygwin.

Member

inkarkat commented May 12, 2012

Speaking of documentation, wouldn't it make sense to move (at least the basic install instructions in the Quick Start Guide) from the Wiki (https://github.com/ginatrapani/todo.txt-cli/wiki/Quick-Start-Guide) to an INSTALL file contained in the package?

Owner

ginatrapani commented May 12, 2012

Yes it would, good call.

On Saturday, May 12, 2012, Ingo Karkat wrote:

Speaking of documentation, wouldn't it make sense to move (at least the
basic install instructions in the Quick Start Guide) from the Wiki (
https://github.com/ginatrapani/todo.txt-cli/wiki/Quick-Start-Guide) to an
INSTALL file contained in the package?


Reply to this email directly or view it on GitHub:
ginatrapani#90 (comment)

http://ginatrapani.org

Also, instead of using cp and chmod it's more common to use the install command.

Contributor

mgarrido commented Sep 19, 2012

I agree with inkarkat. I think that the make install command would require that todo.sh accepted a global settings file (/etc/todo/config). Otherwise just the user who performs the installation gets the configuration file in his ~/.todo.

But then we'd have another problem: what should we set as TODO_DIR in the global configuration file? If we set TODO_DIR=~/.todo, the app would fail because that directory doesn't exist for any user (except perhaps the one who performed the installation). Another option would be to set TODO_DIR=~, but this would create all the needed files (todo.txt, done.txt...) in home.

Contributor

mgarrido commented Oct 4, 2012

I've done some changes in the code related to this issue:

  • Makefile install: copies the script and the completions file, like danohuiginn did. In addition, it creates the config file /etc/todo/config. This file sets TODO_DIR=~/.todo.
  • If not found elsewhere, todo.sh looks for the config file in /etc/todo/config.
  • todo.sh tries to create $TODO_DIR if it doesn't exists.

What do you think this changes?

I've done this in my branch iss90 (I don't know how to attach my branch to this issue, sorry).

Owner

ginatrapani commented Jun 16, 2013

Thanks.

ginatrapani added a commit that referenced this pull request Jun 16, 2013

@ginatrapani ginatrapani merged commit 92f7b72 into todotxt:master Jun 16, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment