New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: Array.prototype.reduce called on null or undefined #7

Closed
ghuntley opened this Issue Jan 15, 2016 · 6 comments

Comments

Projects
None yet
3 participants
@ghuntley

ghuntley commented Jan 15, 2016

Problem

Howdy @todvora - I believe there's something wrong with the version you published a couple hours ago.

Repro

Clone https://github.com/reactiveui/documentation and git reset cf0f22c5cf2c49b91f7453b5bb83010921db2842 - any other commits past this point is where we have disabled the plugin.

Stacktrace

TypeError: Array.prototype.reduce called on null or undefined
TypeError: Array.prototype.reduce called on null or undefined
    at reduce (native)
    at redacted\oss\rxui-documentation\node_modules\gitbook-plugin-image-captions\node_modules\q\q.js:263:21
    at redacted\oss\rxui-documentation\node_modules\gitbook-plugin-image-captions\node_modules\q\q.js:1565:9
    at _fulfilled (redacted\oss\rxui-documentation\node_modules\gitbook-plugin-image-captions\node_modules\q\q.js:834:54)
    at self.promiseDispatch.done (redacted\oss\rxui-documentation\node_modules\gitbook-plugin-image-captions\node_modules\q\q.js:863:30)
    at Promise.promise.promiseDispatch (redacted\oss\rxui-documentation\node_modules\gitbook-plugin-image-captions\node_modules\q\q.js:796:13)
    at redacted\oss\rxui-documentation\node_modules\gitbook-plugin-image-captions\node_modules\q\q.js:857:14
    at runSingle (redacted\oss\rxui-documentation\node_modules\gitbook-plugin-image-captions\node_modules\q\q.js:137:13)
    at flush (redacted\oss\rxui-documentation\node_modules\gitbook-plugin-image-captions\node_modules\q\q.js:125:13)
    at nextTickCallbackWith0Args (node.js:433:9)
@aschempp

This comment has been minimized.

Show comment
Hide comment
@aschempp

aschempp Jan 19, 2016

Contributor

I'm having the same issue, probably cased by #6. Unfortunately I'm not familiar with promises, can't help much here :(

Contributor

aschempp commented Jan 19, 2016

I'm having the same issue, probably cased by #6. Unfortunately I'm not familiar with promises, can't help much here :(

@todvora

This comment has been minimized.

Show comment
Hide comment
@todvora

todvora Jan 31, 2016

Owner

Hi guys, thank you for the error report and sorry for my delay. I’ve been for the last two weeks in the wild, offline.

The first thing I just did do is a rollback to the previous, working version. New release is 0.3.3. Could one of you provide some minimized version of book source code, that causes this crash? Maybe as a markdown snippet, so I could extend the test suite and figure it out?

Thank you!

Owner

todvora commented Jan 31, 2016

Hi guys, thank you for the error report and sorry for my delay. I’ve been for the last two weeks in the wild, offline.

The first thing I just did do is a rollback to the previous, working version. New release is 0.3.3. Could one of you provide some minimized version of book source code, that causes this crash? Maybe as a markdown snippet, so I could extend the test suite and figure it out?

Thank you!

@aschempp

This comment has been minimized.

Show comment
Hide comment
@aschempp

aschempp Jan 31, 2016

Contributor

Thanks! Our books are publicly available at https://github.com/contao/docs
Be aware of the several subfolders with individual books.

Contributor

aschempp commented Jan 31, 2016

Thanks! Our books are publicly available at https://github.com/contao/docs
Be aware of the several subfolders with individual books.

@todvora

This comment has been minimized.

Show comment
Hide comment
@todvora

todvora Feb 3, 2016

Owner

Hi,
I've been able to reproduce this error on books from @aschempp and @ghuntley. It should be fixed now in the release 0.3.4. Could you please later confirm, that everything works ok for you?

@ghuntley: next time you don't have to disable a plugin entirely. It should be enough to specify a version of plugin, that works for you. In this case as "image-captions@0.3.1". This notation comes from gitbook itself and works for every plugin.

Thank you for the bugreport and testing materials!

Regards,
Tomas

Owner

todvora commented Feb 3, 2016

Hi,
I've been able to reproduce this error on books from @aschempp and @ghuntley. It should be fixed now in the release 0.3.4. Could you please later confirm, that everything works ok for you?

@ghuntley: next time you don't have to disable a plugin entirely. It should be enough to specify a version of plugin, that works for you. In this case as "image-captions@0.3.1". This notation comes from gitbook itself and works for every plugin.

Thank you for the bugreport and testing materials!

Regards,
Tomas

@aschempp

This comment has been minimized.

Show comment
Hide comment
@aschempp

aschempp Feb 8, 2016

Contributor

Thanks for the fix! The build worked now :-)
https://travis-ci.org/contao/docs#L8351

Contributor

aschempp commented Feb 8, 2016

Thanks for the fix! The build worked now :-)
https://travis-ci.org/contao/docs#L8351

@todvora

This comment has been minimized.

Show comment
Hide comment
@todvora

todvora Feb 10, 2016

Owner

Thanks for the feedback Andreas! Closing this issue now, hopefully is it fixed for @ghuntley too.

Owner

todvora commented Feb 10, 2016

Thanks for the feedback Andreas! Closing this issue now, hopefully is it fixed for @ghuntley too.

@todvora todvora closed this Feb 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment