Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vertical alignment of item on share menu #2274

Merged
merged 1 commit into from
May 9, 2023

Conversation

fundon
Copy link
Contributor

@fundon fundon commented May 9, 2023

before

Screenshot 2023-05-09 at 9 08 40 AM

after

Screenshot 2023-05-09 at 9 09 26 AM

@vercel
Copy link

vercel bot commented May 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2023 1:25am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2023 1:25am

@fundon fundon temporarily deployed to development May 9, 2023 01:09 — with GitHub Actions Inactive
@fundon fundon temporarily deployed to development May 9, 2023 01:10 — with GitHub Actions Inactive
@fundon fundon temporarily deployed to development May 9, 2023 01:10 — with GitHub Actions Inactive
@fundon fundon temporarily deployed to development May 9, 2023 01:10 — with GitHub Actions Inactive
@fundon fundon temporarily deployed to development May 9, 2023 01:10 — with GitHub Actions Inactive
@fundon fundon temporarily deployed to development May 9, 2023 01:10 — with GitHub Actions Inactive
@fundon fundon requested a review from himself65 May 9, 2023 01:10
@fundon fundon temporarily deployed to development May 9, 2023 01:12 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.03 🎉

Comparison is base (2c18fad) 71.66% compared to head (ca2375b) 71.69%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2274      +/-   ##
==========================================
+ Coverage   71.66%   71.69%   +0.03%     
==========================================
  Files         296      296              
  Lines        6595     6595              
  Branches     1074     1074              
==========================================
+ Hits         4726     4728       +2     
+ Misses       1671     1670       -1     
+ Partials      198      197       -1     
Flag Coverage Δ
e2etest 69.25% <ø> (+0.04%) ⬆️
server-test 73.14% <ø> (ø)
storybook-test 55.14% <ø> (ø)
unittest 36.84% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/component/src/ui/menu/styles.ts 44.00% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fundon fundon temporarily deployed to development May 9, 2023 01:14 — with GitHub Actions Inactive
@fundon fundon temporarily deployed to development May 9, 2023 01:14 — with GitHub Actions Inactive
@fundon fundon temporarily deployed to development May 9, 2023 01:14 — with GitHub Actions Inactive
@fundon fundon temporarily deployed to development May 9, 2023 01:14 — with GitHub Actions Inactive
@fundon fundon temporarily deployed to development May 9, 2023 01:14 — with GitHub Actions Inactive
@fundon fundon temporarily deployed to development May 9, 2023 01:14 — with GitHub Actions Inactive
@fundon fundon temporarily deployed to development May 9, 2023 01:14 — with GitHub Actions Inactive
@fundon fundon temporarily deployed to development May 9, 2023 01:14 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview May 9, 2023 01:21 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 9, 2023 01:25 Inactive
@himself65 himself65 merged commit 11d1d77 into toeverything:master May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants