From ea94d5b57442daddb6d1599480836900b862bdff Mon Sep 17 00:00:00 2001 From: Chen <99816898+donteatfriedrice@users.noreply.github.com> Date: Wed, 8 May 2024 19:09:52 +0800 Subject: [PATCH 1/2] fix: text element issues --- .../root-block/edgeless/components/text/edgeless-text-editor.ts | 1 + packages/blocks/src/root-block/edgeless/utils/text.ts | 1 - packages/blocks/src/surface-block/managers/edit-session.ts | 2 -- 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/packages/blocks/src/root-block/edgeless/components/text/edgeless-text-editor.ts b/packages/blocks/src/root-block/edgeless/components/text/edgeless-text-editor.ts index 5c9495d79e42..edde7281bc47 100644 --- a/packages/blocks/src/root-block/edgeless/components/text/edgeless-text-editor.ts +++ b/packages/blocks/src/root-block/edgeless/components/text/edgeless-text-editor.ts @@ -371,6 +371,7 @@ export class EdgelessTextEditor extends WithDisposable(ShadowlessElement) { color: isCssVariable(color) ? `var(${color})` : color, textAlign, lineHeight: `${lineHeight}px`, + boxSizing: 'content-box', })} class="edgeless-text-editor" > diff --git a/packages/blocks/src/root-block/edgeless/utils/text.ts b/packages/blocks/src/root-block/edgeless/utils/text.ts index a41241d62263..f276eef6876f 100644 --- a/packages/blocks/src/root-block/edgeless/utils/text.ts +++ b/packages/blocks/src/root-block/edgeless/utils/text.ts @@ -140,7 +140,6 @@ export function addText( const id = edgeless.service.addElement(CanvasElementType.TEXT, { xywh: new Bound(modelX, modelY, 32, 32).serialize(), text: new DocCollection.Y.Text(), - hasMaxWidth: false, }); edgeless.doc.captureSync(); const textElement = edgeless.service.getElementById(id); diff --git a/packages/blocks/src/surface-block/managers/edit-session.ts b/packages/blocks/src/surface-block/managers/edit-session.ts index 589b73a178b4..3e2904369987 100644 --- a/packages/blocks/src/surface-block/managers/edit-session.ts +++ b/packages/blocks/src/surface-block/managers/edit-session.ts @@ -98,7 +98,6 @@ const LastPropsSchema = z.object({ fontWeight: CanvasTextFontWeightSchema, fontStyle: CanvasTextFontStyleSchema, fontSize: z.number(), - hasMaxWidth: z.boolean(), }), 'affine:note': z.object({ background: NoteColorsSchema, @@ -178,7 +177,6 @@ export class EditSessionStorage { fontWeight: CanvasTextFontWeight.Regular, fontStyle: CanvasTextFontStyle.Normal, fontSize: 24, - hasMaxWidth: false, }, 'affine:note': { background: DEFAULT_NOTE_COLOR, From 0157d9a9c172e65abc70928c0720dfe8dba2d396 Mon Sep 17 00:00:00 2001 From: Chen <99816898+donteatfriedrice@users.noreply.github.com> Date: Wed, 8 May 2024 19:11:53 +0800 Subject: [PATCH 2/2] chore: clean code --- .../root-block/edgeless/components/text/edgeless-text-editor.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/blocks/src/root-block/edgeless/components/text/edgeless-text-editor.ts b/packages/blocks/src/root-block/edgeless/components/text/edgeless-text-editor.ts index edde7281bc47..6349933aa9f3 100644 --- a/packages/blocks/src/root-block/edgeless/components/text/edgeless-text-editor.ts +++ b/packages/blocks/src/root-block/edgeless/components/text/edgeless-text-editor.ts @@ -28,7 +28,6 @@ export class EdgelessTextEditor extends WithDisposable(ShadowlessElement) { static override styles = css` .edgeless-text-editor { - box-sizing: content-box; position: absolute; left: 0; top: 0;