tofias tofias

tofias commented on pull request kennethreitz/flask-sslify#28
@tofias

Cool. And thanks for making my first experience contributing to an Open Source project so positive.

tofias commented on pull request kennethreitz/flask-sslify#28
@tofias

đź‘Ť

@tofias
  • @tofias 7931c2d
    Changed docs to explain SSLIFY_XXX style config.
tofias commented on pull request kennethreitz/flask-sslify#28
@tofias

I looked at Flask-SQLAlchemy and copied the setdefault method. Was so proud, but you're the boss Ehhh. I'd still be craving for those sexy/clean cr…

tofias commented on pull request kennethreitz/flask-sslify#28
@tofias

What if we change the naming convention to SSLIFY_XXX and use the set default method?

@tofias
@tofias
tofias commented on pull request kennethreitz/flask-sslify#28
@tofias

Fixed.

@tofias
  • @tofias 3e67792
    Ideas about Configing….
tofias commented on pull request kennethreitz/flask-sslify#28
@tofias

Is there a reason to avoid something like c = a or b or a >>> a = False >>> b = True >>> c = a or b or a >>> c is True True >>> a = False >>> b = N…

@tofias
  • @tofias 30ff6a5
    Have skip return False by default.
tofias commented on pull request kennethreitz/flask-sslify#28
@tofias

BUT THANKS!

tofias commented on pull request kennethreitz/flask-sslify#28
@tofias

Man, I'd hate for you to see my other code…

@tofias
  • @tofias 9740d4a
    Removed unnecessary self.app = None block.
@tofias
  • @tofias 7979f0b
    Concat string with format() like a real person would do.
@tofias
  • @tofias 7634d98
    More current_app cleanup.
tofias commented on pull request kennethreitz/flask-sslify#28
@tofias

Okay, so is that what you meant?

@tofias
  • @tofias 2be30b1
    Make work with current_app.
@tofias
tofias commented on pull request kennethreitz/flask-sslify#28
@tofias

Hey, what was the format() thing?

@tofias
  • @tofias d8d9434
    Fixed current_app stuff which I took out b/c … ?
@tofias
  • @tofias 2685703
    Skips can’t be a string.
tofias commented on pull request kennethreitz/flask-sslify#28
@tofias

Okay.

tofias commented on pull request kennethreitz/flask-sslify#28
@tofias

You'd be able to fake that now with SSL_SKIPS if you included just a '/' to be skipped.

tofias commented on pull request kennethreitz/flask-sslify#28
@tofias

Yup.