Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button not appearing in some G-suite apps #1728

Closed
kadrihvl opened this issue May 18, 2020 · 4 comments · Fixed by #1763
Closed

Button not appearing in some G-suite apps #1728

kadrihvl opened this issue May 18, 2020 · 4 comments · Fixed by #1763
Labels
bug has pr released

Comments

@kadrihvl
Copy link

  • OS version: macOS Catalina 10.15.4
  • Browser version: Chrome 81.0.4044.138
  • Extension version: 1.60.9

Relevant integration (if any):

Google Inbox - inbox.google.com
Google Mail - mail.google.com
Google Docs - docs.google.com
Possibly also Google Classroom - classroom.google.com

🐛 Describe the bug

After ticking mentioned apps from TB Integrations tab, button does not appear in the apps.
I'm unsure where to look for TB in Google Classroom as it's not included here (neither are Google Keep examples fyi).

Expected behaviour

Steps to reproduce

Steps to reproduce the behaviour:

  1. Go to ...
  2. ...

Other details or context
@kadrihvl kadrihvl added the bug label May 18, 2020
@kadrihvl
Copy link
Author

Case reference

@tcrammond
Copy link
Contributor

I think the integrations seem to be fine, but the integration list has some issues. It'll show all Google integrations as enabled even if you only enabled one of them - and the others will not work. Will look into it

tcrammond added a commit that referenced this issue Jun 22, 2020
@tcrammond
fix(settings): [WIP] Fix issues with integration checkboxes
d5978f4 
Integrations sharing the same host could be shown as enabled even if they are not. The permission is requested on the full domain, but the list of origins in the UI would ignore the subdomains. Change the integration list to respect subdomain when creating the list of origins. Closes #1728.
@tcrammond tcrammond mentioned this issue Jun 22, 2020
Merged
tcrammond added a commit that referenced this issue Jun 22, 2020
@tcrammond
fix(settings): [WIP] Fix issues with integration checkboxes
5b1d687 
Integrations sharing the same host could be shown as enabled even if they are not. The permission is requested on the full domain, but the list of origins in the UI would ignore the subdomains. Change the integration list to respect subdomain when creating the list of origins. Closes #1728.
@lise-toggl lise-toggl assigned lise-toggl and unassigned lise-toggl Jun 23, 2020
@lise-toggl
Copy link
Contributor

I tested the integrations as well and Classroom isn't working, the selector we're using is out of date. @kadrihvl have there been any requests Classroom? I don't know where the button should be so if we had any user feedback that would be helpful. Or maybe we should drop it if no one is using it?

We also need to remove Inbox since that's no longer around.

tcrammond added a commit that referenced this issue Jun 25, 2020
@tcrammond
fix(settings): Fix issues with integration checkboxes
8f126f2 
Integrations sharing the same host could be shown as enabled even if they are not. The permission is requested on the full domain, but the list of origins in the UI would ignore the subdomains. Change the integration list to respect subdomain when creating the list of origins. Closes #1728.
tcrammond added a commit that referenced this issue Jun 25, 2020
@tcrammond
fix(settings): Fix issues with integration checkboxes
d883dc3 
Integrations sharing the same host could be shown as enabled even if they are not. The permission is requested on the full domain, but the list of origins in the UI would ignore the subdomains. Change the integration list to respect subdomain when creating the list of origins. Closes #1728.
toggl-button-bot added a commit that referenced this issue Jun 25, 2020
@toggl-button-bot
chore(release): 1.62.8 [skip ci]
a197479 
## [1.62.8](1.62.7...1.62.8) (2020-06-25)

### Bug Fixes

* **asana:** Update project selector for My Tasks page ([8aa8f05](8aa8f05)), closes [#1757](#1757)
* **settings:** Fix issues with integration checkboxes ([d883dc3](d883dc3)), closes [#1728](#1728)
@toggl-button-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 1.62.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug has pr released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issues with integration checkboxes toggl/track-extension
4 participants
@tcrammond @kadrihvl @toggl-button-bot @lise-toggl