Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Checkvist support #749

Closed
wants to merge 1 commit into from
Closed

Added Checkvist support #749

wants to merge 1 commit into from

Conversation

crispinb
Copy link

This adds a toggl button to tasks on Checkvist lists.

The lists can get horribly messy with every task having a toggl button, and this may be inappropriate in many cases -- who wants to time the 'carrots' item on their shopping list? So I'm adding the button only if one or more tasks in a given list is tagged with "#toggl".

Buttons are appended to the end of the task text. This doesn't look great, but I found that justifying them (eg. to the RHS) made it hard to associate buttons with tasks, so I chose function over form. Jony Ive I'm not.

Screenshot of simple test list with toggl buttons enabled:

toggl_checkvist

@LulzAugusto
Copy link
Contributor

Hey @crispinb, thanks for contributing. We'll review it within the next few days.

@LulzAugusto
Copy link
Contributor

@crispinb the team discussed your tag approach and we came to the conclusion that it can be a little bit counterintuitive. What do you think about showing the button on hover instead? This way we keep the UI clean and it's easier for the user to find the button.

@crispinb
Copy link
Author

crispinb commented Feb 2, 2017

Agreed, that's obviously a more discoverable approach. Thanks. I'll update the pr when I find a moment to look up how to do it - I don't really know javascript/css being a humble Android / iOS app dev ;)

@bryanph
Copy link
Contributor

bryanph commented Nov 19, 2018

Hey @crispinb, we decided to clear up old PRs to make way for some big refactoring that is upcoming. If you wish to continue work on this PR please feel free to reopen or add an issue for adding Checkvist support!

@bryanph bryanph closed this Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants