CachingStateRepository not working with JSF integration.

[clinton-fillier-vgh]

When implementing a CachingStateRepository I noticed the JSF integration didn't seem to be caching properly. When using the "features" managed bean, a Feature is represented by a NamedFeature. Since NamedFeature doesn't override hashcode() or equals(), it isn't suitable for a key in the cache map.

[chkal]

Although this issue should be fixed with the commit referenced above, I'll keep this issue open. I'll have a deeper look at the problem and perhaps add some tests covering the fix.

[aquaraga]

The same issue exists for the JSP integration as well. I haven't checked if the above commit fixes the issue for JSP - just giving a heads up.

[chkal]

Hey all,

I just had a deeper look at this issue. I refactored the repository to use the unique name of a feature instead of the feature itself as the cache key. I think this is the only way to work around this issue because the repository may be called with either the feature enum value itself or with a NamedFeature representing the same feature. Although NamedFeature implements hashcode/equals correctly now, it is not possible to do the same with the enum to correctly detect an corresponding NamedFeature.

I think it should work fine now. Thank you both for bringing this up and for helping to fix this issue. :)

[clinton-fillier-vgh]

Makes perfect sense! Thanks for looking into this.