Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System Property Activation Strategy #163

Merged
merged 11 commits into from Jun 2, 2016
Merged

Conversation

@cpkelley
Copy link
Contributor

@cpkelley cpkelley commented May 31, 2016

Activate a feature based on a system property. The property is string based and is not case sensitive.

Unit and benchmark tests were also added.

@chkal chkal merged commit fc9a54e into togglz:master Jun 2, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@chkal
Copy link
Member

@chkal chkal commented Jun 2, 2016

Awesome! Thanks a lot! This looks great! Just merged it! 🍻

One idea: What about making the parameter value optional? So if the users omits the value it would mean: "The feature is active if the system property is set with any value". This way users could simply set something like -DdevMode on the command line without the need to set an actual value. So this would be similar to Maven which allows to disable tests by adding -DskipTests to the command line.

Thoughts?

@ryangardner ryangardner deleted the DealerDotCom:property-strategy branch Jun 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants