Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add chinese simple translation #1

Merged
merged 2 commits into from Apr 15, 2019

Conversation

@summerscar
Copy link
Contributor

commented Mar 26, 2019

toio的本体はありませんので、技カードの意味はよく理解できません
reference: トイオ・コレクションあそびかた.pdf

@@ -8,7 +8,8 @@
const translations = {
en: require('./en.json'),
ja: require('./ja.json'),
'ja-Hira': require('./ja-Hira.json')
'ja-Hira': require('./ja-Hira.json'),
'zh-CN': require('./zh-CN.json')

This comment has been minimized.

Copy link
@terado0618

terado0618 Apr 15, 2019

Member

This is case-sensitive.

Suggested change
'zh-CN': require('./zh-CN.json')
'zh-cn': require('./zh-CN.json')
@terado0618

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

Hi @summerscar , 非常感謝 and sorry for late response.
This looks almost ok but needs a fix which I proposed.

@summerscar

This comment has been minimized.

Copy link
Contributor Author

commented Apr 15, 2019

訂正しました @terado0618

@terado0618 terado0618 merged commit 2c0d9da into toio:master Apr 15, 2019
terado0618 added a commit that referenced this pull request Apr 15, 2019
* add chinese simple translation

* fix case-sensitive.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.