-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate the firmware when a uart proxy is synced. #462
Conversation
src/jaguar.toit
Outdated
@@ -20,7 +20,7 @@ import .network | |||
import .uart | |||
|
|||
interface Endpoint: | |||
run device/Device -> none | |||
run device/Device [--validate-firmware] -> none |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this done through a callback? Why not just import the jaguar.toit file and call validate-firmware? What am I missing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hoped I would forget less easily if given as argument.
Changed to a static call.
done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@@ -136,6 +138,14 @@ serve arguments: | |||
else: | |||
Task.group lambdas | |||
|
|||
validate-firmware: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
validate-firmware: | |
validate-firmware -> none: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been done in a later PR.
No description provided.