Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement rest of DataConsumerAgent, unskip its tests #19

Closed
1 of 2 tasks
trentmc opened this issue Feb 19, 2021 · 2 comments · Fixed by #60
Closed
1 of 2 tasks

Implement rest of DataConsumerAgent, unskip its tests #19

trentmc opened this issue Feb 19, 2021 · 2 comments · Fixed by #60

Comments

@trentmc
Copy link
Contributor

trentmc commented Feb 19, 2021

Is your feature request related to a problem? Please describe.

From Ocean v3 netlist, here is
DataconsumerAgent's functionality. It has two key functions: buyDT() and consumeDT().

dataconsumer

The commit 79c52eb fleshed out buyDT(), for the most part. But there's more to do, see below.

Describe the solution you'd like

  • buyDT(): implement proper tests, make changes until tests pass
  • consumeDT(): implement consumeDT(), implement tests, make changes until tests pass
@trentmc trentmc self-assigned this Feb 19, 2021
@trentmc trentmc added this to To do in Main Project Jun 16, 2021
@trentmc trentmc moved this from Backlog - near term to In progress in Main Project Jun 17, 2021
@trentmc trentmc changed the title Finish/fix DataConsumerAgent_test Implement rest of DataConsumerAgent, unskip its tests Jun 17, 2021
@trentmc trentmc moved this from In progress to Backlog - near term in Main Project Jun 17, 2021
LinuxIsCool pushed a commit to LinuxIsCool/tokenspice2 that referenced this issue Jul 11, 2021
…ng for dataconsumer test_buyDT, the transaction limit is currently being exceeded. Check against the agents wallet and the balancer pool state. Also the test should have some more asserts after to verify the accounting of the agent wallet and the pool after the swap.
@trentmc trentmc removed their assignment Jul 13, 2021
@project-bot project-bot bot moved this from Backlog - near term to Done in Main Project Jul 13, 2021
@trentmc trentmc moved this from Done to Backlog - longer term in Main Project Jul 13, 2021
@trentmc trentmc moved this from Backlog - longer term to Backlog - near term in Main Project Jul 13, 2021
@trentmc trentmc moved this from Backlog - near term to Backlog - longer term in Main Project Jul 13, 2021
trentmc added a commit that referenced this issue Aug 17, 2021
For #19 - finish DataconsumerAgent buyDT() and related tests.
@trentmc
Copy link
Contributor Author

trentmc commented Aug 17, 2021

Hi @nvtrang91. An update...

  1. I checked your PR locally. Both tests failed, there were two bugs. I fixed them. I don't know why they didn't show up in the hacking session yesterday. Nonetheless, all good now. I just merged your PR.

  2. I went back to confirm that everything is done for DataconsumerAgent. And I realized that there is more to go: buyDT() was one part, but we still need consumeDT(). The Ocean V3 netlist makes it clear. I updated the issue accordingly, including showing exactly what's DataconsumerAgent does.

For (2), @nvtrang91 would you like to take a swing at consumeDT() ? In the netlist image, you can see its inputs and outputs, just like there are inputs and outputs displayed for buyDT().

@trangnv
Copy link
Collaborator

trangnv commented Aug 17, 2021

Hi @trentmc,
Totally forgot about consumeDT too, I'll work on that for the next session.
Cheers.

Main Project automation moved this from Backlog - longer term to Done Sep 6, 2021
trentmc added a commit that referenced this issue Sep 6, 2021
Fixes last of issue #19 - implement rest of Dataconsumeragent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants