Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One config file for multiple databases/file systems #49

Closed
jayeshagwan1 opened this issue Jan 15, 2020 · 8 comments
Closed

One config file for multiple databases/file systems #49

jayeshagwan1 opened this issue Jan 15, 2020 · 8 comments
Labels
enhancement New feature or request

Comments

@jayeshagwan1
Copy link

Can we use one config file for multiple databases/file systems so that the command will be same always for any type of supported system ?

@jayeshagwan1 jayeshagwan1 changed the title One config file for multiple databases One config file for multiple databases/file systems Jan 15, 2020
@vrajat
Copy link
Member

vrajat commented Jan 15, 2020

Do you mean something like:

[db1]
....

[db2]
....

And choose one through the command line like ?

piicatcher --config cfg.ini db --name db1

I am depending on https://pypi.org/project/click-config-file/ for config file to save effort and right now it doesn't support it.

@vrajat vrajat added the enhancement New feature or request label Jan 16, 2020
@jayeshagwan1
Copy link
Author

After migrating to config file, deep search is not working. I have 2 tables in db, but result is showing only 1st table.
image

image

config file :
[db]
host="10.10.XXX.XXX"
port="3306"
user="XXX"
password="XXXX"
database="XX"
connection-type="mysql"
output-format="json"
scan-type="deep"
list-all=True

@vrajat
Copy link
Member

vrajat commented Jan 20, 2020 via email

@jayeshagwan1
Copy link
Author

Ohh. Even after passing --scan-type in config file, we need to explicitely pass --scan-type deep in cli. Then only it works:

image

@vrajat
Copy link
Member

vrajat commented Jan 20, 2020 via email

@vrajat
Copy link
Member

vrajat commented Jan 21, 2020

I made a mistake in documentation. It should scan_type and not scan-type. Can you give it a try with scan_type ? Fixing the docs

@jayeshagwan1
Copy link
Author

Its working fine now. Just one thing. It takes around 6-10 min to return the result

@vrajat
Copy link
Member

vrajat commented Nov 9, 2021

closing as piicatcher uses a catalog to store database info.

@vrajat vrajat closed this as completed Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants