Expand 'yield' in internal macro calls.#57
Conversation
|
I can't replicate the test failures locally. It seems the test CI is simply running |
taiki-e
left a comment
There was a problem hiding this comment.
I can't replicate the test failures locally. It seems the test CI is simply running
cargo test +stable --all-features, which passes on my machine with flying colors. What am I missing?
I'm not sure if it's a trybuild bug or a rustc bug, (sometimes) test results in CI may differ from those run locally...
taiki-e
left a comment
There was a problem hiding this comment.
Thanks! This looks good to me aside from a few nits.
90175d0 to
c46ada9
Compare
|
Cool. This looks good to me, too! |
|
What's keeping this from being merged? |
|
Sorry, I forgot about this, I'll review it again and merge it if it looks good. |
taiki-e
left a comment
There was a problem hiding this comment.
I noticed this breaks code that has another async stream macro inside the macro.
use tokio::select;
use async_stream::{stream, try_stream};
use futures_util::stream::StreamExt;
async fn do_stuff_async() {}
let s = stream! {
select! {
_ = do_stuff_async() => {
let another_s = try_stream! {
yield;
};
let _: Result<(), ()> = Box::pin(another_s).next().await.unwrap();
},
else => {},
}
yield
};c46ada9 to
3e4e3c1
Compare
3e4e3c1 to
15ec53e
Compare
|
Good catch! Should be good to go. |
15ec53e to
246bdd8
Compare
|
Fixed the rustfmt issue. |
|
Any chance this can find its way into a release? I'm currently exporting |
|
Filed #60 for next release. |
|
Published in v0.3.2. |
|
Awesome, awesome, awesome. Thank you! |
Resolves #27.
As in the title.