Avoid exposure of type names by QueryRejection #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is neccessary, to avoid public exposure of implementation details by the default error message if the extractor fails to deserialize the query parameters into the target type.
|
Thanks! Wanna add a note to the changelog as well? |
davidpdrsn
requested changes
Jul 18, 2022
jplatte
reviewed
Jul 18, 2022
jplatte
approved these changes
Jul 18, 2022
davidpdrsn
reviewed
Jul 18, 2022
axum/CHANGELOG.md
Outdated
| @@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|
|||
| # Unreleased | |||
|
|
|||
| - **fixed:** `QueryRejection` response exposes type names through public interface ([#1171]) | |||
There was a problem hiding this comment.
This almost sounds like the fix was to expose internal types. Maybe this is more clear?
Suggested change
| - **fixed:** `QueryRejection` response exposes type names through public interface ([#1171]) | |
| - **fixed:** Don't expose internal type names in `QueryRejection` responses ([#1171]) |
There was a problem hiding this comment.
huh.. I guess you are right.
This was referenced Jul 19, 2022
davidpdrsn
pushed a commit
that referenced
this pull request
Jul 25, 2022
davidpdrsn
added a commit
that referenced
this pull request
Jul 25, 2022
Merged
davidpdrsn
added a commit
that referenced
this pull request
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is neccessary, to avoid public exposure of implementation details
by the default error message if the extractor fails to deserialize
the query parameters into the target type.
Solution
Removing the
type_namefield fromFailedToDeserializeQueryString.