Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed docs for chained method routing #1355

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

fmeringdal
Copy link
Contributor

Hey, thanks for the amazing work on this crate!

I was browsing the internals of the routing and found some incorrect public documentation for the chained method routing.

Comment on lines 181 to 182
/// // Requests to `GET /` will go to `other_service` and `POST /` will go to
/// // `service`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe swap GET and POST instead of service and other_service (i.e. update the ordering within the sentence)? I think that would make this comment easier to follow.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed! Updated

Comment on lines 245 to 246
/// // Requests to `GET /` will go to `other_handler` and `POST /` will go to
/// // `handler`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@jplatte jplatte enabled auto-merge (squash) September 8, 2022 19:21
@jplatte jplatte merged commit c6be977 into tokio-rs:main Sep 8, 2022
@fmeringdal fmeringdal deleted the fix/chained-method-router-docs branch September 8, 2022 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants