-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ship rc.2 #1363
Ship rc.2 #1363
Conversation
I don't think you have to do anything special. The dev-deps of axum-macros don't really matter. Everything should work if you just don't re-release it. This time you should use exact version constraints for everything though 😉 |
That makes sense! I suppose we still need a new release of axum-extra since it depends on axum as a regular dependency and not a dev-dep. |
Well, since it doesn't have an exact version constraint, the existing |
Co-authored-by: Jonas Platte <jplatte+git@posteo.de>
Does that mean we should do -axum = { path = "../axum", version = "0.6.0-rc.2", default-features = false }
+axum = { path = "../axum", version = "=0.6.0-rc.2", default-features = false } for axum-extra? |
@@ -34,7 +34,7 @@ spa = ["tower-http/fs"] | |||
typed-routing = ["dep:axum-macros", "dep:serde", "dep:percent-encoding"] | |||
|
|||
[dependencies] | |||
axum = { path = "../axum", version = "0.6.0-rc.1", default-features = false } | |||
axum = { path = "../axum", version = "0.6.0-rc.2", default-features = false } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should do one of two things here: Either add an exact version dependency so future rc's or the full axum 0.6.0 don't get used as a dependency of axum-extra 0.4.0-rc.2; or not release another rc of axum-extra at all (it doesn't seem to be required, right?).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assumed it was required but if axum-extra-rc.1 can use axum-rc.2 then yeah we don't need a release of axum-extra. I assumed rc versions were considered incompatible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah they really should be, but aren't. That's why adding the =
to the axum-core dependency is important.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright I've reverted the new version of axum-extra.
I will publish this tomorrow. |
To get #1346 out.
@jplatte do you if there is a way to avoid bumping the version of axum-macros? It doesn't have any changes but currently have to bump it so it depends on the new version of axum.