Add tokio feature & make tokio optional for WASM support #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdorianDark
reviewed
Sep 20, 2022
EdorianDark
reviewed
Sep 20, 2022
jplatte
reviewed
Sep 20, 2022
|
@logankeenan fyi I've started committing to this a bit, so plz don't force push 🙏 |
davidpdrsn
approved these changes
Sep 25, 2022
There was a problem hiding this comment.
Thank you @fisherdarling and @logankeenan for working on this. I did some final touch ups and this is good to merge 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR is a continuation of @fisherdarling's PR since they are very busy and don't have time to see it through at the moment.
It allows Axum to be compiled to WASM, therefore, executable in a browser, Cloudflare Worker, etc...
Solution
This PR adds a tokio feature that enables tokio as well as hyper/tcp and hyper/server. The tokio feature also enables SSE and extract::connect_info.
This is a breaking change since this breaks usages of default_features = false.