Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor initializing tracing-subscriber #1596

Merged
merged 4 commits into from
Nov 30, 2022
Merged

Refactor initializing tracing-subscriber #1596

merged 4 commits into from
Nov 30, 2022

Conversation

tottoto
Copy link
Contributor

@tottoto tottoto commented Nov 29, 2022

Refactoring examples.

davidpdrsn
davidpdrsn reviewed Nov 29, 2022
View reviewed changes
Copy link
Member

@davidpdrsn davidpdrsn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe its just me but I actually prefer using registry() so not sure this an improvement.

@tottoto
Copy link
Contributor Author

tottoto commented Nov 29, 2022

OK! I'll fix to use registry().

@tottoto
Revert "Refactor initializing tracing-subscriber"
c44f65c 
This reverts commit 0876260 in favor of tracing_subscriber::registry.
@davidpdrsn
Copy link
Member

@tottoto isn't that what were doing before? 🤔

@tottoto
Copy link
Contributor Author

tottoto commented Nov 29, 2022

I think we could use EnvFilter::try_from_default_env() in stead of reading RUST_LOG maually.

@tottoto
Copy link
Contributor Author

tottoto commented Nov 30, 2022

Like this 7fdd414.

This change uses Envfilter::try_from_default_env() reading RUST_LOG environment variable.

@davidpdrsn
Copy link
Member

davidpdrsn commented Nov 30, 2022 •
edited
Loading

Ah right yes! Thats a bit nicer indeed :)

@tottoto
Copy link
Contributor Author

tottoto commented Nov 30, 2022

Done.

davidpdrsn
davidpdrsn approved these changes Nov 30, 2022
View reviewed changes
Copy link
Member

@davidpdrsn davidpdrsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Really loving these refactoring PRs you've been doing ❤️

@davidpdrsn davidpdrsn merged commit 6c133be into tokio-rs:main Nov 30, 2022
@tottoto tottoto deleted the refactor-initializing-tracing-subscriber branch November 30, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidpdrsn davidpdrsn davidpdrsn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tottoto @davidpdrsn