impl From<Box<[u8]>> for Bytes #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This missing impl was an inconvenience to me, and there seemed to be no reason for it not to exist. The From<Vec<>> impl in fact turned the Vec into a Box almost immediately. I moved the check for empty slices into the new Box impl since it is needed there too, and added a test case. Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Darksonn
approved these changes
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
This missing impl was an inconvenience to me, and there seemed to be no reason for it not to exist.
The
From<Vec<>>impl in fact turned theVecinto aBoxalmost immediately. I moved the check for empty slices into the newBoximpl since it is needed there too, and added a test case.I hope this meets with your approval and thanks for your attention.