Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UnixListener registration #1139

Merged
merged 1 commit into from Nov 10, 2019

Conversation

@mlang
Copy link
Contributor

mlang commented Nov 9, 2019

Before, Registry::register() on a UnixListener would return
Err(io::ErrorKind::NotFound).
Calling sys::UnixListener::register() instead of sys::UnixListener::reregister()
fixes this.

@Thomasdezeeuw

This comment has been minimized.

Copy link
Collaborator

Thomasdezeeuw commented Nov 9, 2019

Shouldn't we have a failing test on Linux for this? Normally epoll doesn't accept being reregistered without ever registering first.

@Thomasdezeeuw Thomasdezeeuw requested a review from kleimkuhler Nov 9, 2019
Copy link
Contributor

kleimkuhler left a comment

Looks good. I'll add some additional tests for this since the current registration tests only test UnixStream.

@Thomasdezeeuw Thomasdezeeuw merged commit 888a184 into tokio-rs:master Nov 10, 2019
22 checks passed
22 checks passed
FreeBSD 11.2 amd64 Task Summary
Details
tokio-rs.mio Build #20191109.2 succeeded
Details
tokio-rs.mio (Check rustfmt) Check rustfmt succeeded
Details
tokio-rs.mio (Clippy) Clippy succeeded
Details
tokio-rs.mio (Cross Android) Cross Android succeeded
Details
tokio-rs.mio (Cross Android_32) Cross Android_32 succeeded
Details
tokio-rs.mio (Cross Android_ARM64) Cross Android_ARM64 succeeded
Details
tokio-rs.mio (Cross NetBSD) Cross NetBSD succeeded
Details
tokio-rs.mio (Cross Solaris) Cross Solaris succeeded
Details
tokio-rs.mio (Cross iOS_32) Cross iOS_32 succeeded
Details
tokio-rs.mio (Cross iOS_64) Cross iOS_64 succeeded
Details
tokio-rs.mio (Cross iOS_ARM) Cross iOS_ARM succeeded
Details
tokio-rs.mio (Min Rust Linux) Min Rust Linux succeeded
Details
tokio-rs.mio (Min Rust MacOS) Min Rust MacOS succeeded
Details
tokio-rs.mio (Min Rust Windows) Min Rust Windows succeeded
Details
tokio-rs.mio (Minimal versions Linux) Minimal versions Linux succeeded
Details
tokio-rs.mio (Minimal versions Windows) Minimal versions Windows succeeded
Details
tokio-rs.mio (Nightly Linux) Nightly Linux succeeded
Details
tokio-rs.mio (Test --release Linux) Test --release Linux succeeded
Details
tokio-rs.mio (Test Linux) Test Linux succeeded
Details
tokio-rs.mio (Test MacOS) Test MacOS succeeded
Details
tokio-rs.mio (Test Windows) Test Windows succeeded
Details
@Thomasdezeeuw

This comment has been minimized.

Copy link
Collaborator

Thomasdezeeuw commented Nov 10, 2019

@mlang thanks!

@kleimkuhler you'll follow up with some additional testing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.