net: add TcpStream::ready and non-blocking ops #3130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sketch out splitting up awaiting for readiness and performing the operation.
Darksonn
added
A-tokio
Darksonn
reviewed
Nov 11, 2020
|
@Darksonn I added |
Darksonn
reviewed
Nov 12, 2020
Co-authored-by: Alice Ryhl <alice@ryhl.io>
seanmonstar
approved these changes
Nov 12, 2020
This was referenced Nov 12, 2020
Closed
bdonlan
reviewed
Nov 13, 2020
carllerche
added a commit
that referenced
this pull request
Nov 13, 2020
Adds `ready()`, `readable()`, and `writable()` async methods for waiting for socket readiness. Adds `try_send`, `try_send_to`, `try_recv`, and `try_recv_from` for performing non-blocking operations on the socket. This is the UDP equivalent of #3130.
carllerche
added a commit
that referenced
this pull request
Nov 16, 2020
Adds `ready()`, `readable()`, and `writable()` async methods for waiting for socket readiness. Adds `try_send`, `try_send_to`, `try_recv`, and `try_recv_from` for performing non-blocking operations on the socket. This is the UDP equivalent of #3130.
This was referenced Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds function to await for readiness on the TcpStream and non-blocking read/write functions.
async fn TcpStream::ready(Interest)waits for socket readiness satisfying any of the specified interest. There are also two shorthand functions,readable()andwritable().Once the stream is in a ready state, the caller may perform non-blocking operations on it using
try_read()andtry_write(). These function returnWouldBlockif the stream is not, in fact, ready.The await readiness function are similar to
AsyncFd, but do not require a guard. The guard inAsyncFdprotect against a potential race between receiving the readiness notification and clearing it. The guard is needed as Tokio does not control the operations. WithTcpStream, thetry_read()andtry_write()function handle clearing stream readiness as needed.This also exposes
InterestandReady, both defined in Tokio as wrappers for Mio types. These types will also be useful for fixing #3072 .Other I/O types, such as
TcpListener,UdpSocket,Unix*should get similar functions, but this is left for later PRs.Refs: #2968