Fix doc: Let comment match example - #3685
Merged
Merged
Conversation
The example uses `Duration::from_secs(1)` and the explanation says something about 300ms, which does not match. Use "1s" instead in the explanation.
Darksonn
approved these changes
Apr 8, 2021
Darksonn
left a comment
Darksonn
left a comment
Member
There was a problem hiding this comment.
Thanks for noticing the mistake!
Darksonn
added
A-tokio
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example uses
Duration::from_secs(1)and the explanation says something about 300ms, which does not match.Use "1s" instead in the explanation.
As said in the Contributors guide:
😆