Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable running wasm32-unknown-unknown tests #4421

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Conversation

ipetkov
Copy link
Member

@ipetkov ipetkov commented Jan 25, 2022

Motivation

Several of tokio's features (e.g. the channel implementation) do not need a runtime to work, and can be compiled and used for wasm32-unknown-unknown targets

Solution

This change enables running tests for the sync and macros features so that we can note any regressions there

* Several of tokio's features (e.g. the channel implementation) do not
  need a runtime to work, and can be compiled and used for
  wasm32-unknown-unknown targets
* This change enables running tests for the `sync` and `macros` features
  so that we can note any regressions there
@github-actions github-actions bot added the R-loom Run loom tests on this PR label Jan 25, 2022
@ipetkov ipetkov added A-tokio Area: The main tokio crate A-ci Area: The continuous integration setup and removed A-tokio Area: The main tokio crate labels Jan 25, 2022
@ipetkov ipetkov requested a review from a team January 25, 2022 00:53
@ipetkov ipetkov marked this pull request as ready for review January 25, 2022 00:53
Copy link
Member

@carllerche carllerche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me as a first step. What do you think @Darksonn? I'll punt merging to you.

@Darksonn Darksonn merged commit 2747043 into master Jan 27, 2022
@Darksonn Darksonn deleted the ivan/wasm-test branch January 27, 2022 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ci Area: The continuous integration setup A-tokio Area: The main tokio crate R-loom Run loom tests on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants