Enable running wasm32-unknown-unknown tests #4421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Several of tokio's features (e.g. the channel implementation) do not need a runtime to work, and can be compiled and used for wasm32-unknown-unknown targets * This change enables running tests for the `sync` and `macros` features so that we can note any regressions there
ipetkov
added
A-tokio
carllerche
approved these changes
Jan 26, 2022
There was a problem hiding this comment.
Seems fine to me as a first step. What do you think @Darksonn? I'll punt merging to you.
Darksonn
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Motivation
Several of tokio's features (e.g. the channel implementation) do not need a runtime to work, and can be compiled and used for wasm32-unknown-unknown targets
Solution
This change enables running tests for the
syncandmacrosfeatures so that we can note any regressions there