ci: freeze rustc on nightly-2025-01-25 in netlify.toml#7652
Merged
ADD-SP merged 1 commit intotokio-rs:masterfrom Sep 29, 2025
Merged
ci: freeze rustc on nightly-2025-01-25 in netlify.toml#7652ADD-SP merged 1 commit intotokio-rs:masterfrom
netlify.toml#7652ADD-SP merged 1 commit intotokio-rs:masterfrom
Conversation
Signed-off-by: ADD-SP <qiqi.zhang@konghq.com>
Darksonn
approved these changes
Sep 29, 2025
| # 89 | #![cfg_attr(docsrs, feature(doc_auto_cfg))] | ||
| # | ^^^^^^^^^^^^ feature has been removed | ||
| # | | ||
| # = note: removed in 1.58.0; see <https://github.com/rust-lang/rust/pull/138907; for more information |
Member
There was a problem hiding this comment.
Removed in one point fifty eight? That's ancient.
Member
Author
There was a problem hiding this comment.
This version also surprised me, so I checked the PR in the error message, it was merged two days ago: rust-lang/rust@c0ee51f.
Member
There was a problem hiding this comment.
This is just a mistake in the error message and will be fixed in the next nightly: rust-lang/rust#147123
| # = note: merged into `doc_cfg` | ||
| command = """ | ||
| rustup install nightly --profile minimal && cargo doc --no-deps --all-features | ||
| rustup install nightly-2025-01-25 --profile minimal && cargo doc --no-deps --all-features |
Member
There was a problem hiding this comment.
Is this same version as what's used for docs builds?
Member
Author
There was a problem hiding this comment.
This is the same version in ci.yml, there are also some cargo docs in this yml.
tokio/.github/workflows/ci.yml
Line 19 in 8ccf2fb
taiki-e
approved these changes
Sep 29, 2025
Darksonn
pushed a commit
that referenced
this pull request
Jan 2, 2026
Signed-off-by: ADD-SP <qiqi.zhang@konghq.com>
Darksonn
pushed a commit
that referenced
this pull request
Jan 2, 2026
Signed-off-by: ADD-SP <qiqi.zhang@konghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://app.netlify.com/projects/tokio-rs/deploys/68d8b0ea0ad8820008da8f26, I opened a issue to the
lock_api(Amanieu/parking_lot#494).