Conversation
| Ok(()) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I don’t understand the issue yet, but the test failed because the order of attributes in the exported metrics differed each time. Therefore, I added a sorting process during the assertion.
djc
left a comment
There was a problem hiding this comment.
Thanks for working on this! I think this is mostly looking good, but I'd like to have a cleaner commit history where basically each commit could pass CI (though I won't ask you to actually test this). As such:
- Please have reorder the commits to put the clippy commit first, as I assume this is independent of the opentelemtry upgrade
- Please squash the commit with the dependency bump with the commit that fixes the tests, also include the commit for fixing the warnings from deprecations
- Add a version bump for this crate into the commit that updates the CHANGELOG
|
Thank you for your review. |
|
|
@djc
but it should have been:
Should I create a PR to address this now? https://github.com/tokio-rs/tracing-opentelemetry/blob/v0.26.0/CHANGELOG.md |
|
Yes, please. |
Motivation
Update opentelemetry depencencies to 0.25
https://github.com/open-telemetry/opentelemetry-rust/releases/tag/opentelemetry-0.25.0
From version 0.25, OpenTelemetry started using a unified version across all crates.
open-telemetry/opentelemetry-rust#2084
Solution
AttributeSetfrom testsdeployment.environmentsemantic conv todeployment.environment.name