Skip to content

Upgrade to opentelemetry 0.26#169

Merged
djc merged 2 commits into
tokio-rs:v0.1.xfrom
ymgyt:bump-otel
Oct 8, 2024
Merged

Upgrade to opentelemetry 0.26#169
djc merged 2 commits into
tokio-rs:v0.1.xfrom
ymgyt:bump-otel

Conversation

@ymgyt
Copy link
Copy Markdown
Contributor

@ymgyt ymgyt commented Oct 2, 2024

Motivation

Update opentelemetry depencencies to 0.26
https://github.com/open-telemetry/opentelemetry-rust/releases/tag/opentelemetry-0.26.0

Solution

Comment thread Cargo.toml
Comment thread Cargo.toml Outdated
Copy link
Copy Markdown
Collaborator

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread Cargo.toml
Comment thread Cargo.toml Outdated
smallvec = { version = "1.0", optional = true }

# https://github.com/open-telemetry/opentelemetry-rust/issues/2165
tonic = { version = "0.12.3", optional = true }
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should just wait for an upstream fix for this instead of working around it like this.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djc
As suggested in the review and issue, after executing cargo update, the error was resolved, and the line added to Cargo.toml:

tonic = { version = "0.12.3", optional = true }

became unnecessary.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not actually a fix, that's a workaround. Submitted a fix in open-telemetry/opentelemetry-rust#2168.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting the fix PR. I will update this PR once opentelemetry-proto version 0.26.1 is published.

Copy link
Copy Markdown

@lalitb lalitb Oct 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opentelemetry-proto version 0.26.1 - This is released now.

Comment thread src/layer.rs Outdated
@djc
Copy link
Copy Markdown
Collaborator

djc commented Oct 8, 2024

Thanks! I'll get this published tomorrow.

@djc djc merged commit d817cf7 into tokio-rs:v0.1.x Oct 8, 2024
@ymgyt ymgyt deleted the bump-otel branch October 9, 2024 05:14
@djc
Copy link
Copy Markdown
Collaborator

djc commented Oct 9, 2024

  • Published tracing-opentelemetry v0.27.0 at registry crates-io
  • [new tag] v0.27.0 -> v0.27.0
  • Release notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants