Reduce locking in the implementation of Layer::on_close#173
Merged
djc merged 1 commit intotokio-rs:v0.1.xfrom Oct 14, 2024
Merged
Reduce locking in the implementation of Layer::on_close#173djc merged 1 commit intotokio-rs:v0.1.xfrom
Layer::on_close#173djc merged 1 commit intotokio-rs:v0.1.xfrom
Conversation
Only hold the lock on span's extension to retrieve the extension data, but release it before processing and exporting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the implementation of the
on_closemethod, only hold the lock on span's extension to retrieve the extension data, but release it before processing and exporting.Motivation
To achieve optimal performance, span locks should be held for as little time as possible.
It's especially troublesome to hold the lock while arbitrary code in the generic OpenTelemetry span and exporter is called to export the span.
Solution
Reduce the locked code section to what's needed to remove the data of interest from the extension map.