Add level metadata to spans#182
Merged
Merged
Conversation
Collaborator
|
@mladedav any opinions on this? I don't have a strong opinion. |
Collaborator
|
Looks good to me and I think this will be useful. This should just also include a changelog entry for anyone who sets some kind of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #180 for a description.
This PR implements the
OpenTelemetryLayer::with_levelsetting, to disable (enabled by default) attaching the level tag to exported spans.There are several concerns I see before recommending merging this:
levelfield? If so, disable-by-default seems smarter.