From 3a193f3d30e9be038fdc86b464b3a0148acc865a Mon Sep 17 00:00:00 2001 From: Eliza Weisman Date: Fri, 16 Sep 2022 13:15:39 -0700 Subject: [PATCH] chore: fix `clippy::borrow_deref_ref` warnings This fixes some relatively recent clippy lints. --- examples/examples/futures-proxy-server.rs | 2 +- tracing-attributes/src/expand.rs | 2 +- tracing-error/src/error.rs | 2 +- tracing-subscriber/src/fmt/writer.rs | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/examples/examples/futures-proxy-server.rs b/examples/examples/futures-proxy-server.rs index 4c181a2573..b036c18a54 100644 --- a/examples/examples/futures-proxy-server.rs +++ b/examples/examples/futures-proxy-server.rs @@ -86,7 +86,7 @@ pub struct Args { server_addr: SocketAddr, } -#[derive(PartialEq, Debug)] +#[derive(Eq, PartialEq, Debug)] pub enum LogFormat { Plain, Json, diff --git a/tracing-attributes/src/expand.rs b/tracing-attributes/src/expand.rs index 81ee6ed906..7e385566c4 100644 --- a/tracing-attributes/src/expand.rs +++ b/tracing-attributes/src/expand.rs @@ -411,7 +411,7 @@ impl RecordType { RecordType::Value } syn::Type::Reference(syn::TypeReference { elem, .. }) => { - RecordType::parse_from_ty(&*elem) + RecordType::parse_from_ty(elem) } _ => RecordType::Debug, } diff --git a/tracing-error/src/error.rs b/tracing-error/src/error.rs index fea7296257..f28d0c39fd 100644 --- a/tracing-error/src/error.rs +++ b/tracing-error/src/error.rs @@ -109,7 +109,7 @@ impl ErrorImpl { // uphold this is UB. since the `From` impl is parameterized over the original error type, // the function pointer we construct here will also retain the original type. therefore, // when this is consumed by the `error` method, it will be safe to call. - unsafe { &*(self.vtable.object_ref)(self) } + unsafe { (self.vtable.object_ref)(self) } } } diff --git a/tracing-subscriber/src/fmt/writer.rs b/tracing-subscriber/src/fmt/writer.rs index 4aacd6d540..3fe9455664 100644 --- a/tracing-subscriber/src/fmt/writer.rs +++ b/tracing-subscriber/src/fmt/writer.rs @@ -688,7 +688,7 @@ where { type Writer = &'a W; fn make_writer(&'a self) -> Self::Writer { - &*self + self } }