-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
subscriber: fix span data for new, exit, and close events #1334
Merged
hawkw
merged 8 commits into
tokio-rs:master
from
akinnane:span_events_use_subject_span_data
Apr 7, 2021
Merged
subscriber: fix span data for new, exit, and close events #1334
hawkw
merged 8 commits into
tokio-rs:master
from
akinnane:span_events_use_subject_span_data
Apr 7, 2021
Commits on Mar 28, 2021
-
subscriber: fix span data for new, exit, and close events
New, exit and close span events are generated while the current context is set to either `None` or the parent span of the span the event relates to. This causes spans data to be absent from the JSON output in the case of the `None`, or causes the span data to reference the parent's span data. Changing the way the current span is determined allows the correct span to be identified for these events. Trying to access the events `.parent()` allows access of the correct span for the `on_event` actions, while using `.current_span()` works for normal events. Ref: tokio-rs#1032
Configuration menu - View commit details
-
Copy full SHA for d5fda10 - Browse repository at this point
Copy the full SHA d5fda10View commit details
Commits on Mar 29, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 1e95595 - Browse repository at this point
Copy the full SHA 1e95595View commit details -
Configuration menu - View commit details
-
Copy full SHA for 74459ac - Browse repository at this point
Copy the full SHA 74459acView commit details
Commits on Apr 6, 2021
-
subscriber: improve test for tokio-rs#1333
Based on feedback by @hawkw, I've improved the test for tokio-rs#1333 to parse the json output. This is more specifc for the bug and allows easier testing of the different span `on_events`. Ref: tokio-rs#1333 (review)
Configuration menu - View commit details
-
Copy full SHA for c3fd626 - Browse repository at this point
Copy the full SHA c3fd626View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2fac284 - Browse repository at this point
Copy the full SHA 2fac284View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7cc58ba - Browse repository at this point
Copy the full SHA 7cc58baView commit details -
subscriber: improve tokio-rs#1334 tests covering all span states
Use the `on_records` test method check all events have the correct context as described in the PR.
Configuration menu - View commit details
-
Copy full SHA for 4380d43 - Browse repository at this point
Copy the full SHA 4380d43View commit details
Commits on Apr 7, 2021
-
Configuration menu - View commit details
-
Copy full SHA for f99f253 - Browse repository at this point
Copy the full SHA f99f253View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.