Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subscriber: fix span data for new, exit, and close events #1334

Merged
merged 8 commits into from
Apr 7, 2021

Commits on Mar 28, 2021

  1. subscriber: fix span data for new, exit, and close events

    New, exit and close span events are generated while the current
    context is set to either `None` or the parent span of the span the
    event relates to. This causes spans data to be absent from the JSON
    output in the case of the `None`, or causes the span data to reference
    the parent's span data. Changing the way the current span is
    determined allows the correct span to be identified for these
    events. Trying to access the events `.parent()` allows access of the
    correct span for the `on_event` actions, while using `.current_span()`
    works for normal events.
    
    Ref: tokio-rs#1032
    akinnane committed Mar 28, 2021
    Configuration menu
    Copy the full SHA
    d5fda10 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2021

  1. Fix style

    akinnane committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    1e95595 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    74459ac View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2021

  1. subscriber: improve test for tokio-rs#1333

    Based on feedback by @hawkw, I've improved the test for tokio-rs#1333 to parse
    the json output. This is more specifc for the bug and allows easier
    testing of the different span `on_events`.
    
    Ref: tokio-rs#1333 (review)
    akinnane committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    c3fd626 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2fac284 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7cc58ba View commit details
    Browse the repository at this point in the history
  4. subscriber: improve tokio-rs#1334 tests covering all span states

    Use the `on_records` test method check all events have the correct
    context as described in the PR.
    akinnane committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    4380d43 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2021

  1. Configuration menu
    Copy the full SHA
    f99f253 View commit details
    Browse the repository at this point in the history