attributes: update trybuild, fix warnings #2322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkw
added a commit
that referenced
this pull request
Sep 23, 2022
The error messages for these tests appear to have changed a bit with Rust 1.64. This branch runs the tests with `TRYBUILD=overwrite` to update for the latest Rust.
hawkw
added a commit
that referenced
this pull request
Sep 23, 2022
The `async_fn` test file in `tracing-attributes` contains several functions that exist just to test whether they _compile_, rather than make assertions about their behavior. Because these functions are never called, they (naturally) emit dead code warnings. This commit adds `#[allow(dead_code)]` to the compilation tests, plus a comment explaining why we do this.
hawkw
force-pushed
the
eliza/fix-trybuild
branch
from
f9c3eef to
45d30b7
Compare
davidbarsky
approved these changes
Sep 23, 2022
|
Before merging this, I'd change the description of the commit to not say "This branch runs the tests with |
The error messages for these tests appear to have changed a bit with Rust 1.64. This commit includes changes to the `.stderr` file after running the tests with `TRYBUILD=overwrite`, in order to update the expected output for the latest Rust.
The `async_fn` test file in `tracing-attributes` contains several functions that exist just to test whether they _compile_, rather than make assertions about their behavior. Because these functions are never called, they (naturally) emit dead code warnings. This commit adds `#[allow(dead_code)]` to the compilation tests, plus a comment explaining why we do this.
hawkw
force-pushed
the
eliza/fix-trybuild
branch
from
45d30b7 to
e33b02e
Compare
Yup, good suggestion! I've reworded the commit message: 13e32ea |
hawkw
added a commit
that referenced
this pull request
Sep 23, 2022
The error messages for these tests appear to have changed a bit with Rust 1.64. This commit includes changes to the `.stderr` file after running the tests with `TRYBUILD=overwrite`, in order to update the expected output for the latest Rust.
hawkw
added a commit
that referenced
this pull request
Sep 24, 2022
The error messages for these tests appear to have changed a bit with Rust 1.64. This commit includes changes to the `.stderr` file after running the tests with `TRYBUILD=overwrite`, in order to update the expected output for the latest Rust.
hawkw
added a commit
that referenced
this pull request
Sep 24, 2022
The `async_fn` test file in `tracing-attributes` contains several functions that exist just to test whether they _compile_, rather than make assertions about their behavior. Because these functions are never called, they (naturally) emit dead code warnings. This commit adds `#[allow(dead_code)]` to the compilation tests, plus a comment explaining why we do this.
hawkw
added a commit
that referenced
this pull request
Sep 30, 2022
The error messages for these tests appear to have changed a bit with Rust 1.64. This commit includes changes to the `.stderr` file after running the tests with `TRYBUILD=overwrite`, in order to update the expected output for the latest Rust.
hawkw
added a commit
that referenced
this pull request
Sep 30, 2022
The `async_fn` test file in `tracing-attributes` contains several functions that exist just to test whether they _compile_, rather than make assertions about their behavior. Because these functions are never called, they (naturally) emit dead code warnings. This commit adds `#[allow(dead_code)]` to the compilation tests, plus a comment explaining why we do this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attributes: suppress dead code warnings for compile tests
The
async_fntest file intracing-attributescontains severalfunctions that exist just to test whether they compile, rather than
make assertions about their behavior. Because these functions are never
called, they (naturally) emit dead code warnings.
This commit adds
#[allow(dead_code)]to the compilation tests, plus acomment explaining why we do this.
attributes: update trybuild output for Rust 1.64.0
The error messages for these tests appear to have changed a bit with
Rust 1.64. This branch runs the tests with
TRYBUILD=overwritetoupdate for the latest Rust.