New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process MetaCPAN lookup in chunks #48

Merged
merged 1 commit into from Feb 9, 2017

Conversation

Projects
None yet
2 participants
@choroba
Contributor

choroba commented Jan 14, 2017

Fixes #47.

@choroba

This comment has been minimized.

Show comment
Hide comment
@choroba

choroba Jan 14, 2017

Contributor

I'm not sure. Can $releases->next fail for all the files in a chunk, but still return something for another chunk? If it can, next is correct, otherwise, there should be last.

Contributor

choroba commented Jan 14, 2017

I'm not sure. Can $releases->next fail for all the files in a chunk, but still return something for another chunk? If it can, next is correct, otherwise, there should be last.

@choroba

This comment has been minimized.

Show comment
Hide comment
@choroba

choroba Jan 14, 2017

Contributor

BTW, I haven't been able to reproduce the original problem, so I'm not 100% sure this fixes it. I tried to run metacpan lookup on 1020 files and it worked correctly; so, please try to verify that the new code really fixes the issue.

Contributor

choroba commented Jan 14, 2017

BTW, I haven't been able to reproduce the original problem, so I'm not 100% sure this fixes it. I tried to run metacpan lookup on 1020 files and it worked correctly; so, please try to verify that the new code really fixes the issue.

@oalders

This comment has been minimized.

Show comment
Hide comment
@oalders

oalders Feb 9, 2017

Collaborator

Thanks, @choroba !

Collaborator

oalders commented Feb 9, 2017

Thanks, @choroba !

@oalders oalders merged commit 9584ff7 into tokuhirom:master Feb 9, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment