Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work on a fresh install of Mavericks #29

Closed
kevinSuttle opened this issue Dec 5, 2013 · 17 comments
Closed

Does not work on a fresh install of Mavericks #29

kevinSuttle opened this issue Dec 5, 2013 · 17 comments
Labels

Comments

@kevinSuttle
Copy link

Reloaded QL via ZSH and still nothing. Wondering if I'm missing something lower-level.

@ibc
Copy link

ibc commented Jan 11, 2014

Indeed, it does not work on Mavericks.

@zsitro
Copy link

zsitro commented Feb 23, 2014

+1

1 similar comment
@colasbd
Copy link

colasbd commented Feb 24, 2014

+1

@zmwangx
Copy link

zmwangx commented Mar 13, 2014

I cloned the source and built it in Xcode (changing deployment target to 10.9). It works without problem. Maybe it didn't work for you guys because you downloaded the outdated binary (I haven't tested that).


Sorry, I just realized that it is not quicklooking extensions other than .markdown as pointed out in #25 . Maybe you are talking about that?

@tarwich
Copy link
Collaborator

tarwich commented Mar 13, 2014

If someone would like to try v1.3.1, it's running great on my Mavericks, with the exception of some of GitHub markdown not being rendered correctly.

https://github.com/toland/qlmarkdown/releases

@zmwangx
Copy link

zmwangx commented Mar 13, 2014

@tarwich Thanks for the update. However, v1.3.1, just like the one I compiled from master, only quick looks .markdown and ignores .md, .text, etc. that are clearly listed in info.plist. Is it just me and @johnyf, as in #25? Any ideas? Thanks.

@tarwich
Copy link
Collaborator

tarwich commented Mar 14, 2014

No problem. I'll look into it more. However, issue #25 seems to be addressing the file extension, so is this a duplicate issue, or is it completely not working as @kevinSuttle and @ibc seemed to state?

@zmwangx
Copy link

zmwangx commented Mar 14, 2014

@tarwich Honestly "does not work" and "+1" are too short to be informative, so I'm not sure about what their problems are. For me it's just the file extension as in #25—only .markdown works (and works fine in this case).

Update: I mean, @kevinSuttle and @ibc might have just tried it on .md and decided that it didn't work—.md is much more prevalent than .markdown isn't it. We won't know until they come back with extra information.

@BonzaiThePenguin
Copy link

It wasn't working for .md files for me at first, even after relaunching the Finder, but after about a half hour it suddenly started working. Thanks, @tarwich!

@zmwangx
Copy link

zmwangx commented Apr 15, 2014

@BonzaiThePenguin Hmm, interesting... Anyway, for those who can't figure it out, a quick fix is to add com.unknown.md to LSItemContentTypes in Info.plist, as I did in this commit in my fork.

@windgazer
Copy link

+1 Working for me (even some minor github markdown seemed to work). Tested on relatively fresh Maveriks, .md file-extension and to be sure I did use the forced qlmanage -r in terminal.
I wonder if it would help (for new users) to change the readme to contain the link to https://github.com/toland/qlmarkdown/releases as I only found this thread because I noticed the last binary release to be much older than the last changes in the repo :)

@tarwich
Copy link
Collaborator

tarwich commented May 8, 2014

I updated the readme per @windgazer's comment. Hopefully this helps. I also pushed various bugfixes including the Info.plist changes. Hopefully this resolves this issue.

Marking as resolved until 30 days or until I hear one way or another from you guys.

@sjackman
Copy link

sjackman commented May 8, 2014

qlmarkdown works for me on Mavericks after fixing #25.

@tarwich tarwich closed this as completed May 9, 2014
@LeonardoGentile
Copy link

I'm having the same issue. I can see only the source text, not the rendered markdown. I'm also on Mavericks

@LeonardoGentile
Copy link

Sorry I had installed via Brew Cask and it seems it was not the latest version. I've installed it manually and it worked

@tarwich
Copy link
Collaborator

tarwich commented May 15, 2014

I'll look into how to update the cask.

On Thu, May 15, 2014 at 6:02 AM, LeonardoGentile
notifications@github.comwrote:

Sorry I had installed via Brew Cask and it seems it was not the latest
version. I've installed it manually and it worked


Reply to this email directly or view it on GitHubhttps://github.com//issues/29#issuecomment-43196584
.

@tarwich
Copy link
Collaborator

tarwich commented May 15, 2014

Seems brew cask update resolved the issue for me. Feel free to open a new ticket if you need me to look at this again, or if you have other issues.

tarwich added a commit that referenced this issue May 26, 2014
Add support for dynamic UTIs. As mentioned in PR, hopefully this will help with #29, anybody still suffering from #25, and obviously #37.

Thanks for submitting this, @booch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

10 participants