Full HTML output for preview #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where the last character of the HTML output is discarded. The
last character is generally the closing '>' of something like the following:
<p>This is the last paragraph</p>
Adds HEAD and BODY sections to the resulting HTML. Technically the newlines could be discarded, but it aids in readability.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit fixes a bug in the HTML text -- the last character output by
discountis replaced with a '\0' character. It seems that the buffer is already NULL-terminated, so the NULL is not required.The second commit changes the text that is passed to QuickLook to be a complete HTML page. Technically the newlines are not required, but it does aid readability when the preview is dumped to file for inspection.