Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take optional version string as argument #14

Open
jcf opened this issue Nov 15, 2017 · 3 comments
Open

Take optional version string as argument #14

jcf opened this issue Nov 15, 2017 · 3 comments

Comments

@jcf
Copy link

jcf commented Nov 15, 2017

I need to use the latest version of Eastwood to get a fix for incorrectly marking some clojure.spec code as bad.

If I could pass the version of Eastwood I need to check/with-eastwood I wouldn't need a new release of boot-check as well as the release of Eastwood.

Is this something you'd be open to adding? If so I'll try to open a PR with this change this week.

jonase/eastwood#227
jonase/eastwood@b3a1ede

@tolitius
Copy link
Owner

looks like this fix made it to eastwood 0.2.5 which the current (0.1.6) boot-check release points to.

but sure, sounds like a good idea to be able to optionally pass a desired version. Would make sense to do all of them then (i.e. not just eastwood) to be consistent.

@jcf
Copy link
Author

jcf commented Nov 15, 2017

In that case it looks like the fix in Eastwood doesn't work as I'm using boot-check 0.1.6 according to boot show -d, and I still get the error from Eastwood.

[tolitius/boot-check "0.1.6" :scope "test" :exclusions [[org.clojure/clojure] [org.clojure/clojurescript]]]
└── [boot/core "2.7.2" :scope "test"]
    └── [boot/pod "2.7.2" :scope "test"]
        ├── [org.projectodd.shimdandy/shimdandy-impl "1.2.0" :scope "test"]
        └── [org.tcrawley/dynapath "0.2.5" :scope "test"]
specs.clj:155:3: suspicious-expression: and called with 1 args.  (and x) always returns x.  Perhaps there are misplaced parentheses?

Thanks, @tolitius. I'll try and get a PR with optional version numbers over to you this week.

@tolitius
Copy link
Owner

great, thanks.
yea, current boot-check is using the latest eastwood

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants