From c7cc81c6319c6ba8128d53fcd920bead4d1bf399 Mon Sep 17 00:00:00 2001 From: Andrew Morton Date: Fri, 26 Sep 2014 10:18:43 +1000 Subject: [PATCH] o2dlm-fix-null-pointer-dereference-in-o2dlm_blocking_ast_wrapper-checkpatch-fixes WARNING: else is not generally useful after a break or return #47: FILE: fs/ocfs2/dlm/dlmast.c:392: + break; + else total: 0 errors, 1 warnings, 15 lines checked ./patches/o2dlm-fix-null-pointer-dereference-in-o2dlm_blocking_ast_wrapper.patch has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Joel Becker Cc: Mark Fasheh Cc: Srinivas Eeda Signed-off-by: Andrew Morton --- fs/ocfs2/dlm/dlmast.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/ocfs2/dlm/dlmast.c b/fs/ocfs2/dlm/dlmast.c index dbc6cee9a3317e..fd6bbbbd7d78df 100644 --- a/fs/ocfs2/dlm/dlmast.c +++ b/fs/ocfs2/dlm/dlmast.c @@ -389,8 +389,7 @@ int dlm_proxy_ast_handler(struct o2net_msg *msg, u32 len, void *data, if (lock->ml.cookie == cookie) { if (lock->unlock_pending) break; - else - goto do_ast; + goto do_ast; } }