Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[beets] Add ScriptCollection support #42

merged 1 commit into from Apr 1, 2013


None yet
3 participants

xhochy commented Apr 1, 2013

This depends on sampsyo/beets#240

Minor nitpick: could you please prettify the url that ends up in the description? Something like https://github.com/tomahawk-player/tomahawk-resolvers/blob/master/subsonic/content/contents/code/subsonic.js#L412 would be great.


xhochy replied Apr 1, 2013

The host in Beets is just the DNS Name or IP where beet web is running, there is nothing to prettify like in Subsonic.

@hugolm84 hugolm84 commented on the diff Apr 1, 2013

this.host = userConfig.host || 'localhost';
this.port = parseInt(userConfig.port, 10);
if (isNaN(this.port) || !this.port) {
this.port = 8337;
+ // Check if /artist/ is available and we can get enough information for ScriptCollection support
+ xmlHttpRequest.open('GET', this.baseUrl() + '/artist/', true);

hugolm84 Apr 1, 2013


We should add a fail callback in Tomahawk.async for this...

hugolm84 added a commit that referenced this pull request Apr 1, 2013

@hugolm84 hugolm84 merged commit 5a32e7c into tomahawk-player:master Apr 1, 2013

@xhochy xhochy deleted the xhochy:feature/beets-scriptcollection branch Apr 2, 2013

theli-ua pushed a commit to theli-ua/tomahawk-resolvers that referenced this pull request Aug 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment