Permalink
Browse files

Add context for placeholders in 3 UI messages added recently

  • Loading branch information...
1 parent 796df66 commit 7980118516080c988d6431851c147671b614cf8f @lliehu lliehu committed Mar 19, 2013
Showing with 4 additions and 4 deletions.
  1. +4 −4 src/infoplugins/linux/fdonotify/FdoNotifyPlugin.cpp
@@ -190,9 +190,9 @@ FdoNotifyPlugin::nowPlaying( const QVariant& input )
// Remark: If using xml-based markup in notifications, the supplied strings need to be escaped.
QString album;
if ( !hash[ "album" ].isEmpty() )
- album = tr( "<br /><i>on</i> %1" ).arg( Qt::escape( hash[ "album" ] ) );
+ album = tr( "<br /><i>on</i> %1", "%1 is an album name" ).arg( Qt::escape( hash[ "album" ] ) );
- messageText = tr( "%1<br /><i>by</i> %2%3." )
+ messageText = tr( "%1<br /><i>by</i> %2%3.", "%1 is a title, %2 is an artist and %3 is replaced by either the previous message or nothing" )
.arg( Qt::escape( hash[ "title" ] ) )
.arg( Qt::escape( hash[ "artist" ] ) )
.arg( album );
@@ -201,9 +201,9 @@ FdoNotifyPlugin::nowPlaying( const QVariant& input )
{
QString album;
if ( !hash[ "album" ].isEmpty() )
- album = QString( " %1" ).arg( tr( "on \"%1\"" ).arg( hash[ "album" ] ) );
+ album = QString( " %1" ).arg( tr( "on \"%1\"", "%1 is an album name" ).arg( hash[ "album" ] ) );
- messageText = tr( "\"%1\" by %2%3." )
+ messageText = tr( "\"%1\" by %2%3.", "%1 is a title, %2 is an artist and %3 is replaced by either the previous message or nothing" )
.arg( hash[ "title" ] )
.arg( hash[ "artist" ] )
.arg( album );

0 comments on commit 7980118

Please sign in to comment.