New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add markup to the first notification line to overcome problems with KNotify. #179

Merged
merged 1 commit into from Mar 30, 2013

Conversation

Projects
None yet
2 participants
@xhochy
Member

xhochy commented Mar 29, 2013

Add an invisible <i></i> tag to the first line to cheat on Qt's rich text heuristic.

(I do not like doing this commit, but at the moment this seems the only solution to get a broad support for styled notification (should now work at least with Gnome 3, XFCE, awesome and KDE 4))

@xhochy

This comment has been minimized.

Show comment
Hide comment
@xhochy

xhochy Mar 29, 2013

Member

Reported KDE bug: https://bugs.kde.org/show_bug.cgi?id=317572
(so that hopefully this quickfix is not needed anymore)

Member

xhochy commented Mar 29, 2013

Reported KDE bug: https://bugs.kde.org/show_bug.cgi?id=317572
(so that hopefully this quickfix is not needed anymore)

muesli added a commit that referenced this pull request Mar 30, 2013

Merge pull request #179 from xhochy/fix/knotify-recognize-richtext
Add markup to the first notification line to overcome problems with KNotify.

@muesli muesli merged commit a4689a1 into tomahawk-player:master Mar 30, 2013

@xhochy xhochy deleted the xhochy:fix/knotify-recognize-richtext branch Mar 30, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment