Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Add markup to the first notification line to overcome problems with KNotify. #179

Merged
merged 1 commit into from

2 participants

@xhochy
Collaborator

Add an invisible <i></i> tag to the first line to cheat on Qt's rich text heuristic.

(I do not like doing this commit, but at the moment this seems the only solution to get a broad support for styled notification (should now work at least with Gnome 3, XFCE, awesome and KDE 4))

@xhochy
Collaborator

Reported KDE bug: https://bugs.kde.org/show_bug.cgi?id=317572
(so that hopefully this quickfix is not needed anymore)

@muesli muesli merged commit a4689a1 into tomahawk-player:master
@xhochy xhochy deleted the xhochy:fix/knotify-recognize-richtext branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 29, 2013
  1. @xhochy
This page is out of date. Refresh to see the latest.
Showing with 3 additions and 0 deletions.
  1. +3 −0  src/infoplugins/linux/fdonotify/FdoNotifyPlugin.cpp
View
3  src/infoplugins/linux/fdonotify/FdoNotifyPlugin.cpp
@@ -197,6 +197,9 @@ FdoNotifyPlugin::nowPlaying( const QVariant& input )
.arg( Qt::escape( hash[ "artist" ] ) )
.arg( album )
.arg( QString( "\n<i>%1</i>" ).arg( tr( "by", "preposition to link track and artist" ) ) );
+
+ // Dirty hack(TM) so that KNotify/QLabel recognizes the message as Rich Text
+ messageText = QString( "<i></i>%1" ).arg( messageText );
}
else
{
Something went wrong with that request. Please try again.