Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade MSRV, dependencies, edition, whitespace #216

merged 5 commits into from Jul 28, 2019


Copy link

commented Jul 26, 2019

  • The build is already broken on the specified Minimum Supported Rust Version, because regex and tempfile has moved underneath. This is very hard to resolve with pins, because regex fights back. This probably requires them making changes. Upgrade MSRV 1.34.2 instead.
  • Upgrade multipart, url (exported), rand and base64. url (via. percent_encoding) requires >=1.33. rand requires >=1.32.
  • Remove compatibility hacks with 1.24.1, and other deprecated usages.
  • Run rustfmt and dos2unix to make everything consistent, such that we can...
  • Move to edition = "2018", via. cargo fix --edition, as we now require a compiler where this is super stable.

This comment has been minimized.

Copy link

commented Jul 27, 2019

Thanks for the PR. I'll be honest, though: I'm extremely reluctant to merge that kind of PRs, because if I wanted to maliciously introduce a vulnerability in a library, I would do it in a PR like this one, that just changes everything.


This comment has been minimized.

Copy link

commented Jul 27, 2019

I reviewed up to 59ecbb6 and it looks good!
If you submit up to 59ecbb6 (with 09ce36a rebased on top as well), I'll merge.

@FauxFaux FauxFaux force-pushed the FauxFaux:bumps branch from 09ce37a to 3c71fa7 Jul 27, 2019


This comment has been minimized.

Copy link
Contributor Author

commented Jul 27, 2019

Done. The old branch (09ce37a) exists at

The other two commits are just these operations with no other changes, which you can run yourself:

  1. find src examples -name \*.rs -exec dos2unix {} + && dos2unix .gitignore
  2. cargo fmt --all
  3. cargo fix --edition
  4. add edition = "2018" to Cargo.toml
  5. delete extern crate lines

@tomaka tomaka merged commit db66a3b into tomaka:master Jul 28, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed

@FauxFaux FauxFaux deleted the FauxFaux:bumps branch Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.