Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{{ownerName}}/{{repoName}} empty if git remote origin is not set #149

Closed
edeso opened this issue May 7, 2023 · 6 comments
Closed

{{ownerName}}/{{repoName}} empty if git remote origin is not set #149

edeso opened this issue May 7, 2023 · 6 comments

Comments

@edeso
Copy link
Contributor

edeso commented May 7, 2023

shouldn't this raise an error instead of silently ignoring it?

thanks!

@tomasbjerre
Copy link
Owner

Sounds reasonable. But I also don't want complicated code to get this behavior, not worth it.

@edeso
Copy link
Contributor Author

edeso commented May 7, 2023

no problem. was just surprised that i ended up with empty values when it worked on another box. maybe documenting the need for origin when using {{ownerName}}, {{repoName}} can be documented?

couldn't find a list of default placeholders just now. is there one?

@tomasbjerre
Copy link
Owner

@edeso
Copy link
Contributor Author

edeso commented May 7, 2023

i see. well then let me suggest

#150

@tomasbjerre
Copy link
Owner

Thanks

@edeso
Copy link
Contributor Author

edeso commented May 7, 2023

pleasure. thank you :)

@edeso edeso closed this as completed May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants