Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Statie #2

Closed

Conversation

Projects
None yet
2 participants
@TomasVotruba
Copy link

commented Jan 15, 2019

Closes #1

I copied most of the design from https://www.tomasfejfar.cz as we discussed.

I usually comment what changed, why and how Statie works, but as you already use it, I would explain what you already know. If you have some question, just ask anything. I'll answer you.


Next, after this merge, I think the best would be to send this website as pull-request to https://github.com/tomasfejfar/tomasfejfar.cz. Where blog would be in new page - http://tomasfejfar.cz/blog

There you could polish the design, now it would be doing duplicated work.


Then, you could redirect the subdomain and remove this repository. If you need help with Disquss migration, I can give you a hand.

What do you think? :)

Homepage

image

All Posts

image

Post Detail

image

@TomasVotruba

This comment has been minimized.

Copy link
Author

commented Jan 18, 2019

Ready to merge

@tomasfejfar

This comment has been minimized.

Copy link
Owner

commented Jan 19, 2019

Thank you, I'll check it out!

@tomasfejfar

This comment has been minimized.

Copy link
Owner

commented Jan 19, 2019

For some reason exec('php -S localhost:8000 -t output'); in gulp does not work in docker (Symplify/Symplify#1363).

@tomasfejfar

This comment has been minimized.

Copy link
Owner

commented Jan 19, 2019

Could you allow me to push to your branch? It's called something like "allow admin to change this PR" or something like that... I want to get everything ready before I merge it a break my current blog.

@TomasVotruba

This comment has been minimized.

Copy link
Author

commented Jan 19, 2019

I'll try to find it. I thought it's by default

@TomasVotruba

This comment has been minimized.

Copy link
Author

commented Jan 19, 2019

"Allow edits from maintainers" - it was on, I rechecked it. Should work since start

@tomasfejfar

This comment has been minimized.

Copy link
Owner

commented Jan 20, 2019

Weird...

"C:\Program Files\Git\bin\git.exe" push -u --recurse-submodules=check --progress "git://github.com/TomasVotruba/blog-1.git" refs/heads/review/2:refs/heads/migrate-to-statie-next
fatal: remote error:
  You can't push to git://github.com/TomasVotruba/blog-1.git
  Use https://github.com/TomasVotruba/blog-1.git
Done
@TomasVotruba

This comment has been minimized.

Copy link
Author

commented Jan 20, 2019

I merge these locally in new PR. This Github feature didn't work well for me either

Does https://github.com/TomasVotruba/blog-1.git help?

@tomasfejfar

This comment has been minimized.

Copy link
Owner

commented Jan 20, 2019

Huh, that worked, but forced me to login using my credentials instead of SSH key..

@TomasVotruba

This comment has been minimized.

Copy link
Author

commented Jan 20, 2019

Yea, that's stupid feature. I saw other people merge it locally as well.

Also, I don't expect anyone to add anyone commits to my PR. Once coleague added few commits and I didn't know and when force-pushed fixup commits, his work went away.

Show resolved Hide resolved statie.yaml Outdated
gulpfile.js Outdated
@@ -18,6 +18,7 @@ gulp.task('default', function () {

// For the second arg see: https://github.com/floatdrop/gulp-watch/issues/242#issuecomment-230209702
return watch(['source/**/*', '!**/*___jb_tmp___'], function () {
console.log(' [PROCESSING] Regenerating');

This comment has been minimized.

Copy link
@TomasVotruba

TomasVotruba Jan 20, 2019

Author

Good idea actually! Could you add that to Statie gulpfile.js?

This comment has been minimized.

Copy link
@tomasfejfar

tomasfejfar Jan 20, 2019

Owner

Yes, I'll send a PR...

This comment has been minimized.

Copy link
@tomasfejfar

tomasfejfar Jan 20, 2019

Owner

There is one further issue though. The exec is asynchronous, so sometimes the processings and the message from console get mixed up :(

I'm not sure, but I think using execSync migth fix that.

This comment has been minimized.

Copy link
@TomasVotruba

TomasVotruba Jan 20, 2019

Author

I see. If you find a good enough way that makes sense, please share it. Otherwise no need to waste time on this.

This comment has been minimized.

Copy link
@tomasfejfar

tomasfejfar Jan 20, 2019

Owner

Symplify/Symplify#1365

execSync does not work as expected...

@tomasfejfar

This comment has been minimized.

Copy link
Owner

commented Jan 20, 2019

Since I've been using git push --force-with-lease I've never overwritten anyone's work. Do you use it?

From the commits I think 1a4e364 is significant for your efforts of scripting the migration.

It seems like a regex or something is off somewhere is a variable contains dash (some-variable). The include was malformed and the variable did not work.

I imagine it would be hard to detect and fix (you'd need to parse the templates IMHO). So at least a warning that config contains dashed variable might be raised.

@TomasVotruba

This comment has been minimized.

Copy link
Author

commented Jan 20, 2019

Since I've been using git push --force-with-lease I've never overwritten anyone's work. Do you use it?

I think I tried it but it got some extra maintenance so I dropped it. Will try it for alias now to verify.

From the commits I think 1a4e364 is significant for your efforts of scripting the migration.

Yea, I commented there. Not sure if yaml/twig can read it, since I use _ everywhere.

The include was malformed and the variable did not work.

There include needs brackets. Already got that covered in command.

I imagine it would be hard to detect and fix (you'd need to parse the templates IMHO). So at least a warning that config contains dashed variable might be raised.

Not really, just find params with -, rename it to _ and do so in templates.

@TomasVotruba

This comment has been minimized.

Copy link
Author

commented Jan 20, 2019

Made an issue: Symplify/Symplify#1364 I hope I got the problem right

@tomasfejfar tomasfejfar force-pushed the tomasfejfar:gh-pages branch from a26cccf to f6f58a5 Jun 23, 2019

@TomasVotruba TomasVotruba deleted the TomasVotruba:migrate-to-statie-next branch Jun 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.