You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The expression \DateTime::createFromFor...mat, $time, $timezone); of type DateTime|false adds false to the return on line 27 which is incompatible with the return type documented by TomasFejfar\DateTime\Dat...trict::createFromFormat of type DateTime.
The text was updated successfully, but these errors were encountered:
However, I couldn't find a case where \DateTime::createFromFormat() returns false, but there are no warning or errors. If you know of a case, I can write a test.
You are certainly right. But I thought that it would be a nice to handle the edge case anyway to make it futureproof. Also I thought it would be a nice easy pullrequest for someone to do for hacktoberfest :)
The expression \DateTime::createFromFor...mat, $time, $timezone); of type DateTime|false adds false to the return on line 27 which is incompatible with the return type documented by TomasFejfar\DateTime\Dat...trict::createFromFormat of type DateTime.
The text was updated successfully, but these errors were encountered: